Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2168273004: [builtins] move conversions, debugger, handlers, interpreter builtins. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] move conversions, debugger, handlers, interpreter builtins. BUG=v8:5197 Committed: https://crrev.com/cf2594864af2527101a78c7da2b72fc490193403 Cr-Commit-Position: refs/heads/master@{#38012}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase yet again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -521 lines) Patch
M BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
M src/builtins/builtins.cc View 3 chunks +0 lines, -508 lines 0 comments Download
A src/builtins/builtins-conversion.cc View 1 chunk +321 lines, -0 lines 0 comments Download
A src/builtins/builtins-debug.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A src/builtins/builtins-handler.cc View 1 chunk +159 lines, -0 lines 0 comments Download
A src/builtins/builtins-interpreter.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yang
4 years, 5 months ago (2016-07-22 11:43:01 UTC) #2
jgruber
lgtm
4 years, 5 months ago (2016-07-22 11:47:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168273004/1
4 years, 5 months ago (2016-07-22 11:48:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/21364) v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-22 11:49:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168273004/40001
4 years, 5 months ago (2016-07-25 11:20:40 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-25 11:44:38 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 11:44:57 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cf2594864af2527101a78c7da2b72fc490193403
Cr-Commit-Position: refs/heads/master@{#38012}

Powered by Google App Engine
This is Rietveld 408576698