Issue 216823005: Make sure value is a heap number when reusing the double box in BinaryOpICStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216823005: Make sure value is a heap number when reusing the double box in BinaryOpICStub. (Closed)

Created:
6 years, 8 months ago by Hannes Payer (out of office)

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make sure value is a heap number when reusing the double box in BinaryOpICStub. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20501

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -18 lines)			Patch
	M	src/code-stubs-hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-359525.js	View		1 chunk	+14 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

Committed patchset #1 manually as r20501 (presubmit successful).

6 years, 8 months ago (2014-04-04 08:46:57 UTC) #3

Toon Verwaest

6 years, 8 months ago (2014-04-04 09:03:38 UTC) #4

Message was sent while issue was closed.

This fix fixes the mutation problem, however it does not fix the double-run
problem afaict. It could be that the operand is indeed a number, but that the
second operand which used to be a number, is now a string. That would cause a
deopt due to string->number conversion while trying to save, causing the op to
be executed twice.

Expand Messages | Collapse Messages