Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2168223002: DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide (reland) TBR=dgozman Committed: https://crrev.com/52a35bd65dcd8f03dcebae73e9d2dd62fd38ad89 Cr-Commit-Position: refs/heads/master@{#407209}

Patch Set 1 #

Patch Set 2 : lcean #

Patch Set 3 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -65 lines) Patch
M third_party/WebKit/LayoutTests/inspector/components/minimum-size.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/widget-events.html View 1 2 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/widget-events-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/RootView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 1 5 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 6 chunks +18 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 1 2 6 chunks +86 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168223002/20001
4 years, 5 months ago (2016-07-21 22:44:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/264339)
4 years, 5 months ago (2016-07-21 23:28:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168223002/40001
4 years, 5 months ago (2016-07-22 17:13:16 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-22 18:26:00 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 18:29:21 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/52a35bd65dcd8f03dcebae73e9d2dd62fd38ad89
Cr-Commit-Position: refs/heads/master@{#407209}

Powered by Google App Engine
This is Rietveld 408576698