Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: runtime/bin/vmservice_impl.cc

Issue 2168193002: Fuchsia: Build standalone VM. Make it run "Hello, World!". (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice_impl.cc
diff --git a/runtime/bin/vmservice_impl.cc b/runtime/bin/vmservice_impl.cc
index cfb05caf00cfcf5534e207ba16e0fa0eddf44584..9a28b20e0939b199280b26fd9750d91c48ea0e80 100644
--- a/runtime/bin/vmservice_impl.cc
+++ b/runtime/bin/vmservice_impl.cc
@@ -246,14 +246,14 @@ bool VmService::Setup(const char* server_ip,
DartUtils::NewString("_originCheckDisabled"),
Dart_NewBoolean(dev_mode_server));
- // Are we running on Windows?
-#if defined(TARGET_OS_WINDOWS)
- Dart_Handle is_windows = Dart_True();
+ // Signals not supported on Windows or Fuchsia.
+#if defined(TARGET_OS_WINDOWS) || defined(TARGET_OS_FUCHSIA)
+ Dart_Handle has_signals = Dart_False();
#else
- Dart_Handle is_windows = Dart_False();
+ Dart_Handle has_signals = Dart_True();
#endif
- result =
- Dart_SetField(library, DartUtils::NewString("_isWindows"), is_windows);
+ result = Dart_SetField(library,
+ DartUtils::NewString("_hasSignals"), has_signals);
SHUTDOWN_ON_ERROR(result);
// Get _getWatchSignalInternal from dart:io.

Powered by Google App Engine
This is Rietveld 408576698