Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: runtime/bin/vmservice/vmservice_io.dart

Issue 2168193002: Fuchsia: Build standalone VM. Make it run "Hello, World!". (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/vmservice_io.dart
diff --git a/runtime/bin/vmservice/vmservice_io.dart b/runtime/bin/vmservice/vmservice_io.dart
index 680766a00825df177b6329a315b7cfd71b04b9f2..38b29166252caf49287d4f41d44c69fa1225cfeb 100644
--- a/runtime/bin/vmservice/vmservice_io.dart
+++ b/runtime/bin/vmservice/vmservice_io.dart
@@ -21,7 +21,7 @@ String _ip;
bool _autoStart;
// Should the HTTP server run in devmode?
bool _originCheckDisabled;
-bool _isWindows = false;
+bool _hasSignals = true;
Cutch 2016/07/21 20:24:51 This change is likely to break other embedders who
zra 2016/07/22 17:47:20 Restored _isWindows. Added _isFuchsia.
var _signalWatch;
var _signalSubscription;
@@ -177,8 +177,8 @@ _registerSignalHandler() {
// Cannot register for signals.
return;
}
- if (_isWindows) {
- // Cannot register for signals on Windows.
+ if (!_hasSignals) {
+ // Cannot register for signals on Windows or Fuchsia.
return;
}
_signalSubscription = _signalWatch(ProcessSignal.SIGQUIT).listen(_onSignal);

Powered by Google App Engine
This is Rietveld 408576698