Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2168163002: allow curves on side of lines to be very small (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

allow curves on side of lines to be very small Increase the precision of the 'all on one side' pathops angle test to reduce the number of unorderable segments found by the cubics_d3 test. This allows pathsops_unittest release build with -v -V -x to run without error. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168163002 Committed: https://skia.googlesource.com/skia/+/81681949d363f777809af167c70912ca2a612036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/pathops/SkOpAngle.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168163002/1
4 years, 5 months ago (2016-07-21 17:16:28 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:44:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/81681949d363f777809af167c70912ca2a612036

Powered by Google App Engine
This is Rietveld 408576698