third_party/WebKit/Source/platform/graphics/Path.h - Issue 2168133002: Compute exact bounds for SVGPathElement::getBBox()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Path.h

Issue 2168133002: Compute exact bounds for SVGPathElement::getBBox() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: empty subpath workaround Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/Path.h

diff --git a/third_party/WebKit/Source/platform/graphics/Path.h b/third_party/WebKit/Source/platform/graphics/Path.h

index 5497706855a626a90bcde09b6cdcc7c693ff6043..c84b809add4bf32e6649cad6689a6f713b0ff946 100644

--- a/third_party/WebKit/Source/platform/graphics/Path.h

+++ b/third_party/WebKit/Source/platform/graphics/Path.h

@@ -78,8 +78,13 @@ public:

bool contains(const FloatPoint&) const;

bool contains(const FloatPoint&, WindRule) const;

bool strokeContains(const FloatPoint&, const StrokeData&) const;

- FloatRect boundingRect() const;

- FloatRect strokeBoundingRect(const StrokeData&) const;

+ enum class BoundsType {

+ Conservative, // Fast version, includes control points.

+ Exact, // Tight, slower version.

+ };

+ FloatRect boundingRect(BoundsType = BoundsType::Conservative) const;

+ FloatRect strokeBoundingRect(const StrokeData&, BoundsType = BoundsType::Conservative) const;

float length() const;

FloatPoint pointAtLength(float length) const;