Chromium Code Reviews Chromium Code Reviews
Issue 2168123002:
[CacheStorage] Add metrics to the scheduler (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index a96bb359a32a81b581352ffede3f893a40b1607f..b34edbe3ae427f0d1e3ac6405b7f19d74960ac50 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -51993,6 +51993,36 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="ServiceWorkerCache.Scheduler.OperationDuration" units="ms"> |
| + <owner>jkarlin@chromium.org</owner> |
| + <summary> |
| + The time in ms from when an operation is started until it completes. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="ServiceWorkerCache.Scheduler.OperationSlow" enum="BooleanSlow"> |
|
rkaplow
2016/07/21 18:40:01
instead of making a custom enum, why not just use
jkarlin
2016/07/21 20:19:30
Done.
|
| + <owner>jkarlin@chromium.org</owner> |
| + <summary> |
| + An operation is slow if it takes at least 10 seconds to run. If an operation |
| + never completes, it will still be recorded as slow. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="ServiceWorkerCache.Scheduler.QueueDuration" units="ms"> |
| + <owner>jkarlin@chromium.org</owner> |
| + <summary> |
| + The time in ms from when an operation was queued until its task is posted. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="ServiceWorkerCache.Scheduler.QueueLength"> |
|
rkaplow
2016/07/21 18:40:01
can you add a unit
jkarlin
2016/07/21 20:19:30
It's a count, no unit needed.
|
| + <owner>jkarlin@chromium.org</owner> |
| + <summary> |
| + The number of elements in the scheduling queue just before enqueuing a new |
| + operation. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Session.TotalDuration" units="ms"> |
| <owner>mariakhomenko@chromium.org</owner> |
| <owner>fqian@chromium.org</owner> |
| @@ -67976,6 +68006,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="1" label="Skipped"/> |
| </enum> |
| +<enum name="BooleanSlow" type="int"> |
| + <int value="0" label="Not slow"/> |
| + <int value="1" label="Slow"/> |
| +</enum> |
| + |
| <enum name="BooleanStale" type="int"> |
| <int value="0" label="Fresh"/> |
| <int value="1" label="Stale"/> |
| @@ -100564,6 +100599,18 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <affected-histogram name="ServiceWorkerCache.CacheStorage"/> |
| </histogram_suffixes> |
| +<histogram_suffixes name="ServiceWorkerScheduler" separator="." |
| + ordering="prefix"> |
| + <affected-histogram name="ServiceWorkerCache.Scheduler.OperationDuration"/> |
| + <suffix name="CacheStorage" label="Collected from a CacheStorage instance"/> |
| + <suffix name="Cache" label="Collected from a CacheStorageCache instance"/> |
| + <suffix name="BackgroundSyncManager" |
| + label="Collected from a BackgroundSyncManager instance"/> |
| + <affected-histogram name="ServiceWorkerCache.Scheduler.OperationSlow"/> |
| + <affected-histogram name="ServiceWorkerCache.Scheduler.QueueDuration"/> |
| + <affected-histogram name="ServiceWorkerCache.Scheduler.QueueLength"/> |
| +</histogram_suffixes> |
| + |
| <histogram_suffixes name="ServiceWorkerSpecialApps" separator="."> |
| <suffix name="inbox" label="Custom histogram for Inbox"/> |
| <affected-histogram |
