Reorganizing few DCHECKs for better catching of failure.

content/browser/download/save_item.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/save_item.h"
 
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "content/browser/download/save_file.h"
 #include "content/browser/download/save_file_manager.h"
@@ skipping 68 matching lines @@
     // Small downloads might be complete before method has a chance to run.
     return;
   }
   Finish(received_bytes_, false);
   state_ = CANCELED;
   package_->SaveCanceled(this);
 }
 
 // Set finish state for a save item
 void SaveItem::Finish(int64_t size, bool is_success) {
-  DCHECK(has_final_name() || !is_success_);
+  DCHECK(has_final_name());
+  DCHECK(!is_success_);

[no sievers, 2016/07/21 19:08:01]

same here, cannot be split.

[AKV, 2016/07/22 14:26:13]

Done.

   state_ = COMPLETE;
   is_success_ = is_success;
   UpdateSize(size);
 }
 
 void SaveItem::SetTargetPath(const base::FilePath& full_path) {
-  DCHECK(!full_path.empty() && !has_final_name());
+  DCHECK(!full_path.empty());
+  DCHECK(!has_final_name());
   full_path_ = full_path;
 }
 
 void SaveItem::SetTotalBytes(int64_t total_bytes) {
   DCHECK_EQ(0, total_bytes_);
   total_bytes_ = total_bytes;
 }
 
 }  // namespace content