tools: Add a tool to dump the resource_prefetch_predictor database.

tools: Add a tool to dump the resource_prefetch_predictor database.

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.

# Per tools/OWNERS comment.
TBR=thakis

Committed: https://crrev.com/3e8e65ecd39e03bc5d61aa818874bff3ad9ba0b0
Cr-Commit-Position: refs/heads/master@{#406855}

[Benoit L, 2016-07-21 13:02:41]

lizeb@chromium.org changed reviewers:
+ mattcary@chromium.org

[mattcary, 2016-07-21 14:04:29]

lgtm

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
File tools/resource_prefetch_predictor/prefetch_predictor_tool.py (right):

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:32: def
_Score(self):
Add a comment about where this score calculation comes from?

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:54: result =
filter(
Ditto about where these threshold come from.

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:64: query = 'SELECT
* FROM resource_prefetch_predictor_host'
It would be safer to name the fields that you're extracting since you depend on
the order in Entry.FromRow.

[Benoit L, 2016-07-21 14:48:43]

Thanks! All done.

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
File tools/resource_prefetch_predictor/prefetch_predictor_tool.py (right):

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:32: def
_Score(self):
On 2016/07/21 14:04:29, mattcary wrote:
> Add a comment about where this score calculation comes from?

/facepalm
Forgot to upload the latest revision of the patch.
Done.

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:54: result =
filter(
On 2016/07/21 14:04:29, mattcary wrote:
> Ditto about where these threshold come from.

Done.

https://codereview.chromium.org/2168083002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:64: query = 'SELECT
* FROM resource_prefetch_predictor_host'
On 2016/07/21 14:04:29, mattcary wrote:
> It would be safer to name the fields that you're extracting since you depend
on
> the order in Entry.FromRow.

Thanks!
Done.

[Benoit L, 2016-07-21 14:49:25]

Description was changed from

==========
tools: Add a tool to dump the resource_prefetch_predictor database.

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.
==========

to

==========
tools: Add a tool to dump the resource_prefetch_predictor database.

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.

# Per tools/OWNERS comment.
TBR=thakis
==========

[Benoit L, 2016-07-21 14:51:42]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-07-21 14:51:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/2168083002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-07-21 14:51:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 15:25:48]

Description was changed from

==========
tools: Add a tool to dump the resource_prefetch_predictor database.

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.

# Per tools/OWNERS comment.
TBR=thakis
==========

to

==========
tools: Add a tool to dump the resource_prefetch_predictor database.

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.

# Per tools/OWNERS comment.
TBR=thakis
==========

[commit-bot: I haz the power, 2016-07-21 15:25:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 15:27:52]

Description was changed from

==========
tools: Add a tool to dump the resource_prefetch_predictor database.

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.

# Per tools/OWNERS comment.
TBR=thakis
==========

to

==========
tools: Add a tool to dump the resource_prefetch_predictor database.

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.

# Per tools/OWNERS comment.
TBR=thakis

Committed: https://crrev.com/3e8e65ecd39e03bc5d61aa818874bff3ad9ba0b0
Cr-Commit-Position: refs/heads/master@{#406855}
==========

[commit-bot: I haz the power, 2016-07-21 15:27:53]

Patchset 3 (id:??) landed as
https://crrev.com/3e8e65ecd39e03bc5d61aa818874bff3ad9ba0b0
Cr-Commit-Position: refs/heads/master@{#406855}