Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: src/compiler/common-operator.cc

Issue 2168023002: [turbofan] Eliminate unused effectful nodes during representation selection. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix VisitUnused for JS operators. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/representation-change.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/common-operator.cc
diff --git a/src/compiler/common-operator.cc b/src/compiler/common-operator.cc
index f63c073c2c5c1aab55fa3fe903f82fdfa939cf99..0f549a7a62c201b3ba3984a8ff94e9a1b580dc42 100644
--- a/src/compiler/common-operator.cc
+++ b/src/compiler/common-operator.cc
@@ -390,10 +390,10 @@ struct CommonOperatorGlobalCache final {
template <int kEffectInputCount>
struct EffectPhiOperator final : public Operator {
EffectPhiOperator()
- : Operator( // --
- IrOpcode::kEffectPhi, Operator::kPure, // opcode
- "EffectPhi", // name
- 0, kEffectInputCount, 1, 0, 1, 0) {} // counts
+ : Operator( // --
+ IrOpcode::kEffectPhi, Operator::kKontrol, // opcode
+ "EffectPhi", // name
+ 0, kEffectInputCount, 1, 0, 1, 0) {} // counts
};
#define CACHED_EFFECT_PHI(input_count) \
EffectPhiOperator<input_count> kEffectPhi##input_count##Operator;
@@ -827,10 +827,10 @@ const Operator* CommonOperatorBuilder::EffectPhi(int effect_input_count) {
break;
}
// Uncached.
- return new (zone()) Operator( // --
- IrOpcode::kEffectPhi, Operator::kPure, // opcode
- "EffectPhi", // name
- 0, effect_input_count, 1, 0, 1, 0); // counts
+ return new (zone()) Operator( // --
+ IrOpcode::kEffectPhi, Operator::kKontrol, // opcode
+ "EffectPhi", // name
+ 0, effect_input_count, 1, 0, 1, 0); // counts
}
const Operator* CommonOperatorBuilder::BeginRegion(
« no previous file with comments | « no previous file | src/compiler/representation-change.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698