Chromium Code Reviews
Help | Chromium Project | Sign in
(546)

Issue 2168004: view-cache: Refactor ViewCacheHelper and ViewHttpCacheJobFactory... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by rvargas
Modified:
2 years, 10 months ago
Reviewers:
eroman
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

view-cache: Refactor ViewCacheHelper and ViewHttpCacheJobFactory
to use asynchronous interfaces.

BUG=26730
TEST=unittest



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48438

Patch Set 1 #

Total comments: 7

Patch Set 2 : '' #

Total comments: 16

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -121 lines) Lint Patch
M chrome/browser/net/view_http_cache_job_factory.cc View 1 2 2 chunks +69 lines, -23 lines 0 comments 0 errors Download
M net/http/http_cache.h View 1 2 3 chunks +2 lines, -2 lines 0 comments 0 errors Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M net/url_request/view_cache_helper.h View 1 2 2 chunks +103 lines, -8 lines 0 comments 0 errors Download
M net/url_request/view_cache_helper.cc View 1 2 5 chunks +245 lines, -88 lines 0 comments 1 errors Download
A net/url_request/view_cache_helper_unittest.cc View 1 chunk +201 lines, -0 lines 0 comments 1 errors Download
Commit:

Messages

Total messages: 6
rvargas
http://codereview.chromium.org/2168004/diff/1/2 File chrome/browser/net/view_http_cache_job_factory.cc (right): http://codereview.chromium.org/2168004/diff/1/2#newcode70 chrome/browser/net/view_http_cache_job_factory.cc:70: bool ViewHttpCacheJob::ReadRawData(net::IOBuffer* buf, int buf_size, We probably want to ...
3 years, 11 months ago #1
eroman
http://codereview.chromium.org/2168004/diff/1/4 File net/url_request/view_cache_helper.cc (right): http://codereview.chromium.org/2168004/diff/1/4#newcode63 net/url_request/view_cache_helper.cc:63: const std::string& url_prefix) { nit:indent http://codereview.chromium.org/2168004/diff/1/5 File net/url_request/view_cache_helper.h (right): ...
3 years, 11 months ago #2
rvargas
Thanks http://codereview.chromium.org/2168004/diff/1/4 File net/url_request/view_cache_helper.cc (right): http://codereview.chromium.org/2168004/diff/1/4#newcode63 net/url_request/view_cache_helper.cc:63: const std::string& url_prefix) { On 2010/05/25 21:23:54, eroman ...
3 years, 11 months ago #3
eroman
lgtm http://codereview.chromium.org/2168004/diff/8001/9003 File net/url_request/view_cache_helper.cc (right): http://codereview.chromium.org/2168004/diff/8001/9003#newcode91 net/url_request/view_cache_helper.cc:91: context_ = context; I think we should DCHECK(context), ...
3 years, 11 months ago #4
rvargas
Thanks. I added a new file with unit tests. http://codereview.chromium.org/2168004/diff/8001/9003 File net/url_request/view_cache_helper.cc (right): http://codereview.chromium.org/2168004/diff/8001/9003#newcode91 net/url_request/view_cache_helper.cc:91: ...
3 years, 11 months ago #5
eroman
3 years, 11 months ago #6
lgtm.

thanks for adding the unittest!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6