base/BUILD.gn - Issue 2168003003: Replace ICU encoding detection with CED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 2168003003: Replace ICU encoding detection with CED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments/add datafiles back Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index bf7092f43637e145e103ecaf8a2fab58ac8aa82d..e0c37c8e0f0109bc912494254c8589675c8403ab 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -1511,12 +1511,12 @@ component("i18n") {

"i18n/case_conversion.h",

"i18n/char_iterator.cc",

"i18n/char_iterator.h",

+ "i18n/encoding_detection.cc",

+ "i18n/encoding_detection.h",

"i18n/file_util_icu.cc",

"i18n/file_util_icu.h",

"i18n/i18n_constants.cc",

"i18n/i18n_constants.h",

- "i18n/icu_encoding_detection.cc",

- "i18n/icu_encoding_detection.h",

"i18n/icu_string_conversions.cc",

"i18n/icu_string_conversions.h",

"i18n/icu_util.cc",

@@ -1543,6 +1543,7 @@ component("i18n") {

defines = [ "BASE_I18N_IMPLEMENTATION" ]

configs += [ "//build/config/compiler:wexit_time_destructors" ]

public_deps = [

+ "//third_party/ced",

"//third_party/icu",

]

deps = [

« no previous file with comments | « no previous file | base/DEPS » ('j') | net/ftp/ftp_directory_listing_parser.cc » ('J')