base/i18n/encoding_detection.h - Issue 2168003003: Replace ICU encoding detection with CED

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/i18n/encoding_detection.h

Issue 2168003003: Replace ICU encoding detection with CED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	Lei Zhang 2016/08/08 22:09:55 nit: no (c), ditto for .cc file. nit: no (c), ditto for .cc file. Jinsuk Kim 2016/08/09 01:16:19 Done. Show quoted text On 2016/08/08 22:09:55, Lei Zhang wrote: > nit: no (c), ditto for .cc file. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_I18N_ENCODING_DETECTION_H_

	6 #define BASE_I18N_ENCODING_DETECTION_H_

	7

	8 #include <string>

	9

	10 #include "base/compiler_specific.h"

	11 #include "base/i18n/base_i18n_export.h"

	12

	13 namespace base {

	14

	15 // Detect encoding of \|text\| and put the name of encoding in \|encoding\|.

	16 // Returns true on success.

	17 BASE_I18N_EXPORT bool DetectEncoding(const std::string& text,

	18 std::string* encoding) WARN_UNUSED_RESULT;

	19 } // namespace base

	20

	21 #endif // BASE_I18N_ENCODING_DETECTION_H_

OLD	NEW