Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3941)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2167973004: Revert of 📰 Adjust the card display depending on the screen width. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ZineTabletUI
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 9eb479a2dfb426b164b054eb6c723cf14f62ab7b..69ccca4556404bf62277b00a7ce2326223eb1f7f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -16,7 +16,6 @@
import org.chromium.chrome.browser.ntp.NewTabPageLayout;
import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
-import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.snippets.DisabledReason;
import org.chromium.chrome.browser.ntp.snippets.SnippetArticleListItem;
import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder;
@@ -47,7 +46,6 @@
private final NewTabPageLayout mNewTabPageLayout;
private final AboveTheFoldListItem mAboveTheFoldListItem;
private final SnippetHeaderListItem mHeaderListItem;
- private final UiConfig mUiConfig;
private StatusListItem mStatusListItem;
private final List<NewTabPageListItem> mNewTabPageListItems;
private final ItemTouchCallbacks mItemTouchCallbacks;
@@ -112,10 +110,9 @@
* @param newTabPageLayout the layout encapsulating all the above-the-fold elements
* (logo, search box, most visited tiles)
* @param snippetsBridge the bridge to interact with the snippets service.
- * @param uiConfig the NTP UI configuration, to be passed to created views.
*/
public NewTabPageAdapter(NewTabPageManager manager, NewTabPageLayout newTabPageLayout,
- SnippetsBridge snippetsBridge, UiConfig uiConfig) {
+ SnippetsBridge snippetsBridge) {
mNewTabPageManager = manager;
mNewTabPageLayout = newTabPageLayout;
mAboveTheFoldListItem = new AboveTheFoldListItem();
@@ -124,7 +121,6 @@
mNewTabPageListItems = new ArrayList<NewTabPageListItem>();
mWantsSnippets = true;
mSnippetsBridge = snippetsBridge;
- mUiConfig = uiConfig;
mStatusListItem = StatusListItem.create(snippetsBridge.getDisabledReason(), this, manager);
loadSnippets(new ArrayList<SnippetArticleListItem>());
@@ -187,12 +183,12 @@
}
if (viewType == NewTabPageListItem.VIEW_TYPE_HEADER) {
- return new SnippetHeaderViewHolder(mRecyclerView, mUiConfig);
+ return new SnippetHeaderViewHolder(
+ SnippetHeaderListItem.createView(parent), mRecyclerView);
}
if (viewType == NewTabPageListItem.VIEW_TYPE_SNIPPET) {
- return new SnippetArticleViewHolder(
- mRecyclerView, mNewTabPageManager, mSnippetsBridge, mUiConfig);
+ return new SnippetArticleViewHolder(mRecyclerView, mNewTabPageManager, mSnippetsBridge);
}
if (viewType == NewTabPageListItem.VIEW_TYPE_SPACING) {
@@ -200,7 +196,7 @@
}
if (viewType == NewTabPageListItem.VIEW_TYPE_STATUS) {
- return new StatusListItem.ViewHolder(mRecyclerView, mUiConfig);
+ return new StatusListItem.ViewHolder(mRecyclerView);
}
return null;

Powered by Google App Engine
This is Rietveld 408576698