Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2167973002: Revert of Support early associated interface binding on ChannelMojo (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@explicit-channel-ipc-task-runner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support early associated interface binding on ChannelMojo (patchset #5 id:80001 of https://codereview.chromium.org/2163633003/ ) Reason for revert: Lots of browser_tests failures. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/266272 Original issue's description: > Support early associated interface binding on ChannelMojo > > Changes the associated bindings implementation for ChannelMojo > such that remote interfaces can be acquired immediately upon > ChannelMojo construction rather than having to wait for connection > on the IO thread. > > Simplifies the Channel bootstrapping process, removing a round-trip > Init message (and in fact the entire IPC::mojom::Boostrap interface) > since there's no need to actually exchange associated interface handles > over the pipe. Instead both sides can assume the other will use a fixed, > reserved endpoint ID for their IPC::mojom::Channel interface. > > This also removes the restriction that associated interfaces must be > added to a Channel after Init. Instead the same constraints apply as > with AddFilter: an associated interface, like a filter, may be added > at any time as long as either Init hasn't been called OR the remote > process hasn't been launched. > > The result of this CL is that any place it's safe to AddFilter, > it's also safe to AddAssociatedInterface; and any place it's safe to > Send, it's also safe to GetRemoteAssociatedInterface and begin using > any such remote interface immediately. > > Remote interface requests as well as all messages to remote interfaces > retain FIFO with respect to any Send calls on the same thread. Local > interface request dispatch as well as all messages on locally bound > associated interfaces retain FIFO with respect to any OnMessageReceived > calls on the same thread. > > BUG=612500, 619202 > > Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091 > Cr-Commit-Position: refs/heads/master@{#406720} TBR=yzshen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612500, 619202 Committed: https://crrev.com/f192a075bcd935672ec1db5de7308a96bfd34685 Cr-Commit-Position: refs/heads/master@{#406739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -330 lines) Patch
M ipc/ipc.mojom View 1 chunk +10 lines, -6 lines 0 comments Download
M ipc/ipc_channel.h View 2 chunks +7 lines, -3 lines 0 comments Download
M ipc/ipc_channel_mojo.h View 5 chunks +26 lines, -11 lines 0 comments Download
M ipc/ipc_channel_mojo.cc View 8 chunks +98 lines, -56 lines 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 6 chunks +13 lines, -15 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 5 chunks +13 lines, -18 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 5 chunks +41 lines, -43 lines 0 comments Download
M ipc/ipc_message_pipe_reader.h View 5 chunks +17 lines, -4 lines 0 comments Download
M ipc/ipc_message_pipe_reader.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M ipc/ipc_mojo_bootstrap.h View 2 chunks +40 lines, -8 lines 0 comments Download
M ipc/ipc_mojo_bootstrap.cc View 15 chunks +314 lines, -145 lines 0 comments Download
M ipc/ipc_mojo_bootstrap_unittest.cc View 4 chunks +13 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Support early associated interface binding on ChannelMojo
4 years, 5 months ago (2016-07-21 01:33:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167973002/1
4 years, 5 months ago (2016-07-21 01:33:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 01:34:05 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 01:35:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f192a075bcd935672ec1db5de7308a96bfd34685
Cr-Commit-Position: refs/heads/master@{#406739}

Powered by Google App Engine
This is Rietveld 408576698