Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 216793014: Move dispatchBeforeUnloadEvent to WebFrame, part 2/3. (Closed)

Created:
6 years, 9 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, jochen+watch_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Move dispatchBeforeUnloadEvent to WebFrame, part 2/3. BUG=357782 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Avi (use Gerrit)
You asked for this...
6 years, 9 months ago (2014-03-29 01:36:51 UTC) #1
Charlie Reis
[+site-isolation-reviews] Ah, great! I just saw https://codereview.chromium.org/217543005/ as well. LGTM.
6 years, 9 months ago (2014-03-29 01:43:23 UTC) #2
Avi (use Gerrit)
On 2014/03/29 01:43:23, Charlie Reis wrote: > [+site-isolation-reviews] > > Ah, great! I just saw ...
6 years, 9 months ago (2014-03-29 01:46:10 UTC) #3
Charlie Reis
On 2014/03/29 01:46:10, Avi wrote: > On 2014/03/29 01:43:23, Charlie Reis wrote: > > [+site-isolation-reviews] ...
6 years, 9 months ago (2014-03-29 01:48:44 UTC) #4
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-03-29 19:56:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/216793014/1
6 years, 8 months ago (2014-03-29 19:57:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 21:30:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 21:30:14 UTC) #8
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-03-30 17:19:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/216793014/1
6 years, 8 months ago (2014-03-30 17:22:22 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 20:42:16 UTC) #11
Message was sent while issue was closed.
Change committed as 260463

Powered by Google App Engine
This is Rietveld 408576698