Issue 216793013: Revert 260245 "Revert 260198 "[VideoPlayer] Browser tests for ne..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216793013: Revert 260245 "Revert 260198 "[VideoPlayer] Browser tests for ne..." (Closed)

Created:
6 years, 9 months ago by Charlie Reis

Modified:
6 years, 9 months ago

Reviewers:
yoshiki

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 260245 "Revert 260198 "[VideoPlayer] Browser tests for ne..." Undoing the revert, since the MultiProfileFileManagerBrowserTest failure was caused by Blink 170311 instead. Sorry for the disruption. > Revert 260198 "[VideoPlayer] Browser tests for new separated vid..." > > I suspect it was the cause of these file_manager_browsertest.cc failures: > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22673 > > > [VideoPlayer] Browser tests for new separated video player app > > > > BUG=357621 > > TEST=manually tested > > > > R=hirono@chromium.org > > TBR=arv@chromium.org > > # TBRing for adding a resource. > > > > Review URL: https://codereview.chromium.org/209853011 > > TBR=yoshiki@chromium.org > > Review URL: https://codereview.chromium.org/216183006 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260328

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -6 lines)			Patch
M	trunk/src/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/component_extension_resources.grd	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/video_player/js/background.js	View	3 chunks	+14 lines, -4 lines	0 comments	Download
A +	trunk/src/chrome/browser/resources/video_player/js/error_util.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/resources/video_player/js/test_util.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/video_player/js/video_player.js	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/video_player/js/video_player_scripts.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/video_player/manifest.json	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	trunk/src/chrome/test/data/extensions/api_test/file_manager_browsertest/open_video_files.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r260328.