Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 216793009: Remove shape-padding (Closed)

Created:
6 years, 8 months ago by rwlbuis
Modified:
6 years, 8 months ago
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove shape-padding This patch removes shape-padding support, since it can be used only with shape-inside. Shape-inside support has been removed in r170260. BUG=356778 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170590

Patch Set 1 #

Patch Set 2 : Fix webexposed/css-properties-as-js-properties.html #

Patch Set 3 : Rebase against ToT #

Patch Set 4 : Remove m_padding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -668 lines) Patch
M LayoutTests/animations/resources/animation-test-helpers.js View 1 3 chunks +2 lines, -3 lines 0 comments Download
D LayoutTests/fast/shapes/parsing/parsing-shape-padding.html View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/fast/shapes/parsing/parsing-shape-padding-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-shape-property-aliases.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-shape-property-aliases-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/BoxShape.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/shapes/BoxShape.cpp View 3 chunks +0 lines, -62 lines 0 comments Download
M Source/core/rendering/shapes/BoxShapeTest.cpp View 1 2 5 chunks +4 lines, -64 lines 0 comments Download
M Source/core/rendering/shapes/PolygonShape.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/shapes/PolygonShape.cpp View 4 chunks +0 lines, -180 lines 0 comments Download
M Source/core/rendering/shapes/RasterShape.h View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/rendering/shapes/RasterShape.cpp View 3 chunks +0 lines, -82 lines 0 comments Download
M Source/core/rendering/shapes/RectangleShape.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/shapes/RectangleShape.cpp View 2 chunks +0 lines, -129 lines 0 comments Download
M Source/core/rendering/shapes/Shape.h View 1 2 3 2 chunks +4 lines, -9 lines 0 comments Download
M Source/core/rendering/shapes/Shape.cpp View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.cpp View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
rwlbuis
PTAL
6 years, 8 months ago (2014-03-28 20:57:43 UTC) #1
Zoltan
go clean up go, lgtm!
6 years, 8 months ago (2014-03-28 21:18:52 UTC) #2
rwlbuis
More work related to shape-inside removal. shape-padding only applies to shape-inside, so it can be ...
6 years, 8 months ago (2014-03-28 21:25:48 UTC) #3
leviw_travelin_and_unemployed
Wow, yeah, lgtm! Thanks for the cleanup!
6 years, 8 months ago (2014-03-31 22:25:11 UTC) #4
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-03-31 22:26:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/216793009/20001
6 years, 8 months ago (2014-03-31 22:26:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 22:27:21 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/style/RenderStyle.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-03-31 22:27:22 UTC) #8
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-04-01 15:32:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/216793009/30001
6 years, 8 months ago (2014-04-01 15:32:29 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 16:04:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-01 16:04:52 UTC) #12
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-04-01 16:11:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/216793009/50001
6 years, 8 months ago (2014-04-01 16:11:46 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 16:31:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-01 16:31:13 UTC) #16
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-04-01 17:09:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/216793009/50001
6 years, 8 months ago (2014-04-01 17:10:00 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 18:18:19 UTC) #19
Message was sent while issue was closed.
Change committed as 170590

Powered by Google App Engine
This is Rietveld 408576698