Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 216793007: Fix the ninja build on mac to use nm/readelf from the Android toolchain instead of the host system. (Closed)

Created:
6 years, 9 months ago by djsollen
Modified:
6 years, 9 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix the ninja build on mac to use nm/readelf from the Android toolchain instead of the host system. BUG=skia:2338 Committed: http://code.google.com/p/skia/source/detail?r=13985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M platform_tools/android/bin/android_setup.sh View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
6 years, 9 months ago (2014-03-28 16:47:46 UTC) #1
mtklein
lgtm
6 years, 9 months ago (2014-03-28 16:49:06 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 9 months ago (2014-03-28 16:49:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/216793007/1
6 years, 9 months ago (2014-03-28 16:49:56 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 18:09:01 UTC) #5
Message was sent while issue was closed.
Change committed as 13985

Powered by Google App Engine
This is Rietveld 408576698