Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 216793006: Roll back tests/TileGridTest.cpp back to where ASAN was happy. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com, ian_cottrell
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Roll back tests/TileGridTest.cpp back to where ASAN was happy. Revert "Change tilegrid test to test it directly, rather than through SkPicture" This reverts commit 7ae3bc7ffb3068b0585ad313d5c43ff1aab99737. Revert "Fix result order reliance" This reverts commit be4825c873856d8a6a91ea19cf1499da4b0a1fc1. BUG=skia:2345 Committed: http://code.google.com/p/skia/source/detail?r=13981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -80 lines) Patch
M tests/TileGridTest.cpp View 3 chunks +114 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
Not seeing any action on this build breaking bug, I'd like to just roll this ...
6 years, 9 months ago (2014-03-28 14:59:06 UTC) #1
reed1
lgtm
6 years, 9 months ago (2014-03-28 16:34:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/216793006/1
6 years, 9 months ago (2014-03-28 16:34:22 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 17:57:15 UTC) #4
Message was sent while issue was closed.
Change committed as 13981

Powered by Google App Engine
This is Rietveld 408576698