Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 216793002: Add picture ID support in RtcVideoEncoder. (Closed)

Created:
6 years, 9 months ago by wuchengli
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Add picture ID support in RtcVideoEncoder. When Forward Error Correction (FEC) packets arrive, jitter buffer will consider them missing. The jitter buffer needs to use the picture ID to see if a new frame is continuous to the previous frame. Without picture ID, the jitter buffer will not determine any frame decodable after FEC. Video will hang until the jitter buffer drops all packets and requests a key frame. BUG=347477 TEST=Run apprtc.appspot.com between Linux and CrOS. Run apprtc.appspot.com loopback on CrOS. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260269

Patch Set 1 #

Patch Set 2 : change rand() to base::RandInt() #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M content/renderer/media/rtc_video_encoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder.cc View 1 6 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
wuchengli
PTAL. I didn't increment |picture_id_| in InitEncode and Encode because they are called on different ...
6 years, 9 months ago (2014-03-28 10:34:22 UTC) #1
Ami GONE FROM CHROMIUM
lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 9 months ago (2014-03-28 14:53:20 UTC) #2
holmer
On 2014/03/28 14:53:20, Ami Fischman wrote: > lgtm > > To unsubscribe from this group ...
6 years, 9 months ago (2014-03-28 14:54:53 UTC) #3
Ami GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-28 14:57:15 UTC) #4
wuchengli
The CQ bit was checked by wuchengli@chromium.org
6 years, 9 months ago (2014-03-28 15:29:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/216793002/40001
6 years, 9 months ago (2014-03-28 15:34:00 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 17:07:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-28 17:07:01 UTC) #8
Ami GONE FROM CHROMIUM
The CQ bit was checked by fischman@chromium.org
6 years, 9 months ago (2014-03-28 17:11:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/216793002/40001
6 years, 9 months ago (2014-03-28 17:13:35 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 19:04:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-28 19:04:05 UTC) #12
Ami GONE FROM CHROMIUM
The CQ bit was checked by fischman@chromium.org
6 years, 9 months ago (2014-03-28 19:16:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/216793002/40001
6 years, 9 months ago (2014-03-28 19:20:53 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 20:50:09 UTC) #15
Message was sent while issue was closed.
Change committed as 260269

Powered by Google App Engine
This is Rietveld 408576698