Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json

Issue 2167883004: [Skia] Convert SKPs to a CIPD package (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Non-canary bot provides --upload_to_partner_bucket Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json
diff --git a/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json b/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json
index 4aab2afa1496c3eeb474584293cc6543727cd268..c04c3b70cf453a7ab3b1be1f65a4e004649a4aaa 100644
--- a/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json
+++ b/scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json
@@ -676,6 +676,16 @@
"cmd": [
"python",
"-u",
+ "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",
+ "[SLAVE_BUILD]/skia/infra/bots/assets/skp/VERSION",
+ "/path/to/tmp/"
+ ],
+ "name": "read skp VERSION"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os.path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",
"[SLAVE_BUILD]/tmp",
"511"
@@ -699,26 +709,6 @@
"python",
"-u",
"\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",
- "[SLAVE_BUILD]/tmp/SKP_VERSION",
- "/path/to/tmp/"
- ],
- "name": "Get downloaded SKP_VERSION"
- },
- {
- "cmd": [
- "python",
- "-u",
- "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",
- "[SLAVE_BUILD]/skia/SKP_VERSION",
- "/path/to/tmp/"
- ],
- "name": "Get expected SKP_VERSION"
- },
- {
- "cmd": [
- "python",
- "-u",
- "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",
"[SLAVE_BUILD]/tmp/SK_IMAGE_VERSION",
"/path/to/tmp/"
],
@@ -955,6 +945,8 @@
"slavename:skiabot-linux-compile-000",
"--tag",
"stepname:test_skia on Ubuntu",
+ "--cipd-package",
+ "skp:skia/bots/skp:version:0",
"def456",
"--",
"--workdir",
@@ -1132,6 +1124,8 @@
"slavename:skiabot-linux-compile-000",
"--tag",
"stepname:perf_skia on Ubuntu",
+ "--cipd-package",
+ "skp:skia/bots/skp:version:0",
"def456",
"--",
"--workdir",

Powered by Google App Engine
This is Rietveld 408576698