Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json

Issue 2167883004: [Skia] Convert SKPs to a CIPD package (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Non-canary bot provides --upload_to_partner_bucket Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json
diff --git a/scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json b/scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json
index 23371fc19798d20458645920b3dd28ed3ce4da01..321b8ad569af6f7eca60778c4ba94e1ad9a68a83 100644
--- a/scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json
+++ b/scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json
@@ -133,6 +133,28 @@
"cmd": [
"python",
"-u",
+ "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os.path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",
+ "[SLAVE_BUILD]/tmp",
+ "511"
+ ],
+ "name": "makedirs tmp_dir",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import sys, os@@@",
+ "@@@STEP_LOG_LINE@python.inline@path = sys.argv[1]@@@",
+ "@@@STEP_LOG_LINE@python.inline@mode = int(sys.argv[2])@@@",
+ "@@@STEP_LOG_LINE@python.inline@if not os.path.isdir(path):@@@",
+ "@@@STEP_LOG_LINE@python.inline@ if os.path.exists(path):@@@",
+ "@@@STEP_LOG_LINE@python.inline@ print \"%s exists but is not a dir\" % path@@@",
+ "@@@STEP_LOG_LINE@python.inline@ sys.exit(1)@@@",
+ "@@@STEP_LOG_LINE@python.inline@ os.makedirs(path, mode)@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
"runhooks"
],
@@ -195,6 +217,68 @@
"cmd": [
"python",
"-u",
+ "\nimport os, sys\nfrom common import chromium_utils # Error? See https://crbug.com/584783.\n\n\nif os.path.exists(sys.argv[1]):\n chromium_utils.RemoveDirectory(sys.argv[1])\n",
+ "[SLAVE_BUILD]/skp_output"
+ ],
+ "name": "rmtree skp_output",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import os, sys@@@",
+ "@@@STEP_LOG_LINE@python.inline@from common import chromium_utils # Error? See https://crbug.com/584783.@@@",
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@if os.path.exists(sys.argv[1]):@@@",
+ "@@@STEP_LOG_LINE@python.inline@ chromium_utils.RemoveDirectory(sys.argv[1])@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os.path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",
+ "[SLAVE_BUILD]/skp_output",
+ "511"
+ ],
+ "name": "makedirs skp_output",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import sys, os@@@",
+ "@@@STEP_LOG_LINE@python.inline@path = sys.argv[1]@@@",
+ "@@@STEP_LOG_LINE@python.inline@mode = int(sys.argv[2])@@@",
+ "@@@STEP_LOG_LINE@python.inline@if not os.path.isdir(path):@@@",
+ "@@@STEP_LOG_LINE@python.inline@ if os.path.exists(path):@@@",
+ "@@@STEP_LOG_LINE@python.inline@ print \"%s exists but is not a dir\" % path@@@",
+ "@@@STEP_LOG_LINE@python.inline@ sys.exit(1)@@@",
+ "@@@STEP_LOG_LINE@python.inline@ os.makedirs(path, mode)@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "[CUSTOM_/_B_WORK]/skia/infra/bots/assets/skp/create.py",
+ "--chrome_src_path",
+ "[CUSTOM_/_B_WORK]/src",
+ "--browser_executable",
+ "[CUSTOM_/_B_WORK]/src/out/Release/chrome",
+ "--target_dir",
+ "[SLAVE_BUILD]/skp_output",
+ "--upload_to_partner_bucket"
+ ],
+ "cwd": "[CUSTOM_/_B_WORK]/skia",
+ "env": {
+ "AWS_CREDENTIAL_FILE": "[SLAVE_BUILD]/tmp/.boto",
+ "BOTO_CONFIG": "[SLAVE_BUILD]/tmp/.boto",
+ "CHROME_HEADLESS": "1",
+ "PATH": "[DEPOT_TOOLS]:%(PATH)s"
+ },
+ "name": "Recreate SKPs"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"\nimport os\nimport urllib2\n\nTOKEN_FILE = '.depot_tools_oauth2_tokens'\nTOKEN_FILE_BACKUP = '.depot_tools_oauth2_tokens.old'\nTOKEN_URL = 'http://metadata/computeMetadata/v1/project/attributes/depot_tools_auth_update_skps'\n\nreq = urllib2.Request(TOKEN_URL, headers={'Metadata-Flavor': 'Google'})\ncontents = urllib2.urlopen(req).read()\n\nhome = os.path.expanduser('~')\ntoken_file = os.path.join(home, TOKEN_FILE)\nif os.path.isfile(token_file):\n os.rename(token_file, os.path.join(home, TOKEN_FILE_BACKUP))\n\nwith open(token_file, 'w') as f:\n f.write(contents)\n"
],
"name": "depot-tools-auth login",
@@ -223,18 +307,16 @@
{
"cmd": [
"python",
- "[BUILD]/scripts/slave/skia/recreate_skps.py",
- "[CUSTOM_/_B_WORK]/src",
- "[CUSTOM_/_B_WORK]/src/out/Release/chrome"
+ "[BUILD]/scripts/slave/skia/upload_skps.py",
+ "--target_dir",
+ "[SLAVE_BUILD]/skp_output"
],
"cwd": "[CUSTOM_/_B_WORK]/skia",
"env": {
- "AWS_CREDENTIAL_FILE": "[SLAVE_BUILD]/tmp/.boto",
- "BOTO_CONFIG": "[SLAVE_BUILD]/tmp/.boto",
"CHROME_HEADLESS": "1",
"PATH": "[DEPOT_TOOLS]:%(PATH)s"
},
- "name": "Recreate SKPs"
+ "name": "Upload SKPs"
},
{
"cmd": [

Powered by Google App Engine
This is Rietveld 408576698