[Skia] Convert SKPs to a CIPD package

scripts/slave/recipe_modules/skia/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 import json
 import os
 import re
 import sys
 
@@ skipping 195 matching lines @@
 
     # Set some important variables.
     self.resource_dir = self.skia_dir.join('resources')
     self.images_dir = self.slave_dir.join('skimage')
     if not self.m.path.exists(self.infrabots_dir.join(
         'assets', 'skimage', 'VERSION')):
       # TODO(borenet): Remove this once enough time has passed.
       self.images_dir = self.slave_dir.join('images')
     self.skia_out = self.skia_dir.join('out', self.builder_name)
     self.swarming_out_dir = self.make_path(self.m.properties['swarm_out_dir'])
-    self.local_skp_dir = self.slave_dir.join('skps')
+    self.local_skp_dir = self.slave_dir.join('skp')
+    if not self.m.path.exists(self.infrabots_dir.join(
+        'assets', 'skp', 'VERSION')):
+      # TODO(borenet): Remove this once enough time has passed.
+      self.local_skp_dir = self.slave_dir.join('skps')
     if not self.is_compile_bot:
       self.skia_out = self.slave_dir.join('out')
     self.tmp_dir = self.m.path['slave_build'].join('tmp')
+    if not self.m.path.exists(self.tmp_dir):
+      self._run_once(self.m.file.makedirs,
+                     'tmp_dir',
+                     self.tmp_dir,
+                     infra_step=True)
 
     self.gsutil_env_chromium_skia_gm = self.gsutil_env(BOTO_CHROMIUM_SKIA_GM)
 
     self.device_dirs = None
     self._ccache = None
     self._checked_for_ccache = False
     self.configuration = self.builder_spec['configuration']
     self.default_env.update({'SKIA_OUT': self.skia_out,
                              'BUILDTYPE': self.configuration})
     self.default_env.update(self.builder_spec['env'])
@@ skipping 295 matching lines @@
         local_images_dir,
         test_expected_version=TEST_EXPECTED_SK_IMAGE_VERSION,
         test_actual_version=self.m.properties.get(
             'test_downloaded_sk_image_version',
             TEST_EXPECTED_SK_IMAGE_VERSION))
 
   def _copy_images(self):
     """Download and copy test images if needed."""
     version_file = self.infrabots_dir.join('assets', 'skimage', 'VERSION')
     if self.m.path.exists(version_file):
-      version_file = self.infrabots_dir.join('assets', 'skimage', 'VERSION')
       test_data = self.m.properties.get(
-          'test_actual_skp_version', TEST_EXPECTED_SKP_VERSION)
+          'test_downloaded_sk_image_version', TEST_EXPECTED_SK_IMAGE_VERSION)
       version = self._readfile(version_file,
                                name='Get downloaded skimage VERSION',
                                test_data=test_data).rstrip()
       self._writefile(self.m.path.join(self.tmp_dir, VERSION_FILE_SK_IMAGE),
                       version)
     else:
       # TODO(borenet): Remove this once enough time has passed.
       version = self.check_actual_version(
           VERSION_FILE_SK_IMAGE,
           self.tmp_dir,
@@ skipping 21 matching lines @@
         VERSION_FILE_SKP,
         GS_SUBDIR_TMPL_SKP,
         tmp_dir,
         local_skp_dir,
         test_expected_version=TEST_EXPECTED_SKP_VERSION,
         test_actual_version=self.m.properties.get(
             'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION))
 
   def _copy_skps(self):
     """Download and copy the SKPs if needed."""
-    version = self.check_actual_version(
-        VERSION_FILE_SKP,
-        self.tmp_dir,
-        test_actual_version=self.m.properties.get(
-            'test_downloaded_skp_version',
-            TEST_EXPECTED_SKP_VERSION),
-    )
+    version_file = self.infrabots_dir.join('assets', 'skp', 'VERSION')
+    if self.m.path.exists(version_file):
+      test_data = self.m.properties.get(
+          'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION)
+      version = self._readfile(version_file,
+                               name='Get downloaded SKP VERSION',
+                               test_data=test_data).rstrip()
+      self._writefile(self.m.path.join(self.tmp_dir, VERSION_FILE_SKP), version)
+    else:
+      # TODO(borenet): Remove this once enough time has passed.
+      version = self.check_actual_version(
+          VERSION_FILE_SKP,
+          self.tmp_dir,
+          test_actual_version=self.m.properties.get(
+              'test_downloaded_skp_version',
+              TEST_EXPECTED_SKP_VERSION),
+      )
     self.copy_dir(
         version,
         VERSION_FILE_SKP,
         self.tmp_dir,
         self.local_skp_dir,
         self.device_dirs.skp_dir,
         test_expected_version=self.m.properties.get(
             'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION),
         test_actual_version=self.m.properties.get(
             'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION))
@@ skipping 266 matching lines @@
     # Don't bother to include role, which is always Test.
     # TryBots are uploaded elsewhere so they can use the same key.
     blacklist = ['role', 'is_trybot']
 
     flat = []
     for k in sorted(self.builder_cfg.keys()):
       if k not in blacklist:
         flat.append(k)
         flat.append(self.builder_cfg[k])
     return flat