Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 2167883003: [webcrypto] Align importKey()'s comments to reference the latest spec. (Closed)

Created:
4 years, 5 months ago by eroman
Modified:
4 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, blink-reviews, tfarina, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Align importKey()'s comments to reference the latest spec. (version 4f58244457f8e785c5fbfa9db2735473f9e74ccf of https://github.com/w3c/webcrypto) Committed: https://crrev.com/d6bf7a31699898b9ef06c2ccbbf7fb73e665b8cc Cr-Commit-Position: refs/heads/master@{#407012}

Patch Set 1 #

Patch Set 2 : ad another comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -28 lines) Patch
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/importKey-failures-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/importKey-badParameters-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp View 1 2 chunks +85 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
eroman
4 years, 5 months ago (2016-07-21 05:22:21 UTC) #2
Ryan Sleevi
lgtm
4 years, 5 months ago (2016-07-21 16:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167883003/20001
4 years, 5 months ago (2016-07-22 01:12:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 03:18:07 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:19:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6bf7a31699898b9ef06c2ccbbf7fb73e665b8cc
Cr-Commit-Position: refs/heads/master@{#407012}

Powered by Google App Engine
This is Rietveld 408576698