Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1933)

Issue 2167873002: Fix mips64el typo in snapshot_toolchain.gni. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix mips64el typo in snapshot_toolchain.gni. I had written "mipsel64", not "mips64el". R=machenbach@chromium.org, milko.leporis@imgtec.com BUG=629057 Committed: https://crrev.com/8526513ce59a8ecc3d6ce20328a35255ad29dbe9 Cr-Commit-Position: refs/heads/master@{#37951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M snapshot_toolchain.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-20 22:23:35 UTC) #1
lmilko
LGTM
4 years, 5 months ago (2016-07-21 06:41:39 UTC) #6
Michael Achenbach
lgtm
4 years, 5 months ago (2016-07-21 07:22:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167873002/1
4 years, 5 months ago (2016-07-21 17:16:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 17:18:12 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:20:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8526513ce59a8ecc3d6ce20328a35255ad29dbe9
Cr-Commit-Position: refs/heads/master@{#37951}

Powered by Google App Engine
This is Rietveld 408576698