Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2167853004: Removing 'AllowScopedIO' exception from SecurityKeyAuthHandlerLinux (Closed)

Created:
4 years, 5 months ago by joedow
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp_dir
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing 'AllowScopedIO' exception from SecurityKeyAuthHandlerLinux BUG=591739

Patch Set 1 #

Patch Set 2 : Adding more functionality #

Patch Set 3 : More fixes! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -154 lines) Patch
M PRESUBMIT.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/security_key/security_key_auth_handler.h View 2 chunks +4 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_auth_handler_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_auth_handler_linux.cc View 1 2 9 chunks +257 lines, -61 lines 0 comments Download
M remoting/host/security_key/security_key_auth_handler_linux_unittest.cc View 1 2 8 chunks +185 lines, -73 lines 0 comments Download
M remoting/host/security_key/security_key_auth_handler_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_auth_handler_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_auth_handler_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_extension.h View 3 chunks +10 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_extension.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M remoting/host/security_key/security_key_extension_session.h View 2 chunks +7 lines, -3 lines 0 comments Download
M remoting/host/security_key/security_key_extension_session.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/host/security_key/security_key_extension_session_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/host/security_key/security_key_socket.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2161013003 Patch 100001

Messages

Total messages: 12 (12 generated)
joedow
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-21 01:51:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167853004/1
4 years, 5 months ago (2016-07-21 01:52:12 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-21 02:02:08 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/221999)
4 years, 5 months ago (2016-07-21 02:02:09 UTC) #4
joedow
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-22 00:10:27 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167853004/20001
4 years, 5 months ago (2016-07-22 00:10:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-22 00:39:10 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/205600)
4 years, 5 months ago (2016-07-22 00:39:11 UTC) #8
joedow
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-22 03:15:39 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167853004/40001
4 years, 5 months ago (2016-07-22 03:17:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-22 03:47:49 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:47:50 UTC) #12 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698