Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2167853003: [DevTools] Always report encodedDataLength in Network.ResponseReceived. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Header sizes in devtools Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
index 1856656ed0fb9f2696f0900ed29e97d12a7e229f..fa0a9ae67da7ad6d9ac8e37ad0a6e76368d8a42e 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
@@ -627,8 +627,13 @@ void InspectorNetworkAgent::didReceiveData(LocalFrame*, unsigned long identifier
if (data) {
NetworkResourcesData::ResourceData const* resourceData = m_resourcesData->data(requestId);
- if (resourceData && (!resourceData->cachedResource() || resourceData->cachedResource()->getDataBufferingPolicy() == DoNotBufferData || isErrorStatusCode(resourceData->httpStatusCode())))
- m_resourcesData->maybeAddResourceData(requestId, data, dataLength);
+ if (resourceData) {
+ if (!resourceData->dataLength() && resourceData->rawHeaderSize() > 0)
+ encodedDataLength -= resourceData->rawHeaderSize();
dgozman 2016/07/21 21:07:59 I don't like this. Let's fix it async_handler inst
allada 2016/07/22 17:19:32 Done.
+
+ if (!resourceData->cachedResource() || resourceData->cachedResource()->getDataBufferingPolicy() == DoNotBufferData || isErrorStatusCode(resourceData->httpStatusCode()))
+ m_resourcesData->maybeAddResourceData(requestId, data, dataLength);
+ }
}
frontend()->dataReceived(requestId, monotonicallyIncreasingTime(), dataLength, encodedDataLength);

Powered by Google App Engine
This is Rietveld 408576698