third_party/WebKit/LayoutTests/http/conf/apache2-httpd-2.2.conf - Issue 2167853003: [DevTools] Always report encodedDataLength in Network.ResponseReceived.

Side by Side Diff: third_party/WebKit/LayoutTests/http/conf/apache2-httpd-2.2.conf

Issue 2167853003: [DevTools] Always report encodedDataLength in Network.ResponseReceived. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Quic Tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« net/url_request/url_request_http_job_unittest.cc ('K') | « net/url_request/url_request_http_job_unittest.cc ('k') | third_party/WebKit/LayoutTests/http/conf/apache2-httpd-2.4.conf » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/data-xfer-resource.php » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 ServerTokens Prod

1 LockFile "/tmp/WebKit/httpd.lock"	2 LockFile "/tmp/WebKit/httpd.lock"

2 ScoreBoardFile "/tmp/WebKit/httpd.scoreboard"	3 ScoreBoardFile "/tmp/WebKit/httpd.scoreboard"

3	4

4 Timeout 300	5 Timeout 300

5 KeepAlive On	6 KeepAlive On

6 MaxKeepAliveRequests 100	7 MaxKeepAliveRequests 999
	Adam Rice 2016/09/01 08:57:28 I'm not sure this solves the problem of Apache sen I'm not sure this solves the problem of Apache sending a Keep-Alive header that varies in length. In other words, I see no fundamental reason why a single content_shell can't send 900 requests over the same HTTP connection while running layout tests, at which point the Keep-Alive header will get shorter and your tests will fail. This would make them flaky in a very hard-to-reproduce manner. allada 2016/09/07 06:01:12 A quick search found apx 4.2k (some may have multi Show quoted text On 2016/09/01 08:57:28, Adam Rice wrote: > I'm not sure this solves the problem of Apache sending a Keep-Alive header that > varies in length. > > In other words, I see no fundamental reason why a single content_shell can't > send 900 requests over the same HTTP connection while running layout tests, at > which point the Keep-Alive header will get shorter and your tests will fail. > This would make them flaky in a very hard-to-reproduce manner. A quick search found apx 4.2k (some may have multiple requests, but it also shards the tests) tests that use HTTP, although I do agree this should be avoided, there is no easy solution. I increased the number to help mitigate this concern. Adam Rice 2016/09/07 06:35:52 MaxKeepAliveRequests 0 seems to work. "0" means u Show quoted text On 2016/09/07 06:01:12, Blaise wrote: > On 2016/09/01 08:57:28, Adam Rice wrote: > > I'm not sure this solves the problem of Apache sending a Keep-Alive header > that > > varies in length. > > > > In other words, I see no fundamental reason why a single content_shell can't > > send 900 requests over the same HTTP connection while running layout tests, at > > which point the Keep-Alive header will get shorter and your tests will fail. > > This would make them flaky in a very hard-to-reproduce manner. > > A quick search found apx 4.2k (some may have multiple requests, but it also > shards the tests) tests that use HTTP, although I do agree this should be > avoided, there is no easy solution. I increased the number to help mitigate this > concern. MaxKeepAliveRequests 0 seems to work. "0" means unlimited here. This makes Apache stop including the count in the Keep-Alive: header. Since Apache is stopped at the end of the layout tests anyway, there should be no adverse affects.
7 KeepAliveTimeout 15	8 KeepAliveTimeout 999

8	9

9 MaxClients 150	10 MaxClients 150

10 MaxRequestsPerChild 100000	11 MaxRequestsPerChild 100000

11	12

12 LoadModule authz_host_module libexec/apache2/mod_authz_host.so	13 LoadModule authz_host_module libexec/apache2/mod_authz_host.so

13 LoadModule include_module libexec/apache2/mod_include.so	14 LoadModule include_module libexec/apache2/mod_include.so

14 LoadModule log_config_module libexec/apache2/mod_log_config.so	15 LoadModule log_config_module libexec/apache2/mod_log_config.so

15 LoadModule headers_module libexec/apache2/mod_headers.so	16 LoadModule headers_module libexec/apache2/mod_headers.so

16 LoadModule ssl_module libexec/apache2/mod_ssl.so	17 LoadModule ssl_module libexec/apache2/mod_ssl.so

17 LoadModule mime_module libexec/apache2/mod_mime.so	18 LoadModule mime_module libexec/apache2/mod_mime.so

(...skipping 124 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
142 Order allow,deny	143 Order allow,deny

143 Deny from all	144 Deny from all

144 Satisfy All	145 Satisfy All

145 </Files>	146 </Files>

146	147

147 <Directory ~ ".*\.\.namedfork">	148 <Directory ~ ".*\.\.namedfork">

148 Order allow,deny	149 Order allow,deny

149 Deny from all	150 Deny from all

150 Satisfy All	151 Satisfy All

151 </Directory>	152 </Directory>

OLD	NEW