Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2167853002: [Heap] Fix ArrayBuffer_SemiSpaceCopyMultipleTasks to respect PPC page size (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Heap] Fix ArrayBuffer_SemiSpaceCopyMultipleTasks to respect PPC page size The testcase allocates JSArraybuffer on 2 separate pages which should be on the New space. In the testcase semi space size is set to 2MB. Since page size on PPC is 4MB the semi new space size defaults to 4MB. Therefore when allocating 2nd buffer, scavenge GC kicks in as from-space is filled up and copies 1st buffer to to-space. Now, the 2nd buffer also gets allocated on the same to-space, therefore both buffer end up being on the same page. This fix should allocate enough semi new space to contain 2 pages (for all platform). The testcase was added as part of https://codereview.chromium.org/2036643002 R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/b1683f050a750df8d0fd22eae1f82a05019c54c1 Cr-Commit-Position: refs/heads/master@{#38028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL, thanks.
4 years, 5 months ago (2016-07-20 21:40:07 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-21 16:25:47 UTC) #2
Michael Lippautz
lgtm, thanks!
4 years, 5 months ago (2016-07-25 11:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167853002/1
4 years, 4 months ago (2016-07-25 15:40:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 15:59:54 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 16:02:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1683f050a750df8d0fd22eae1f82a05019c54c1
Cr-Commit-Position: refs/heads/master@{#38028}

Powered by Google App Engine
This is Rietveld 408576698