Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Issue 2167843005: switch translate element loading domain (Closed)

Created:
4 years, 5 months ago by ftang
Modified:
4 years, 5 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, zkoch1, barakt_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

switch translate element loading domain BUG=630068 Committed: https://crrev.com/149a3740a58de22cd0ebbd0fe962a9f116c2e776 Cr-Commit-Position: refs/heads/master@{#407279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/translate/core/browser/translate_script.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
ftang
bug 630068
4 years, 5 months ago (2016-07-22 19:59:48 UTC) #4
groby-ooo-7-16
lgtm
4 years, 5 months ago (2016-07-22 21:30:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167843005/1
4 years, 5 months ago (2016-07-22 22:04:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 22:09:20 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 22:10:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/149a3740a58de22cd0ebbd0fe962a9f116c2e776
Cr-Commit-Position: refs/heads/master@{#407279}

Powered by Google App Engine
This is Rietveld 408576698