Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4216)

Unified Diff: chrome/browser/memory/tab_manager_web_contents_data.cc

Issue 2167843004: Discardable property support on TabManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change to auto-discardable Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/memory/tab_manager_web_contents_data.h ('k') | chrome/browser/memory/tab_stats.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory/tab_manager_web_contents_data.cc
diff --git a/chrome/browser/memory/tab_manager_web_contents_data.cc b/chrome/browser/memory/tab_manager_web_contents_data.cc
index e3f973997c2737bd56b2cc25f79b36df503c2a23..f8d75d2cc151eb1207b27cb82bd4a13dd9f2db83 100644
--- a/chrome/browser/memory/tab_manager_web_contents_data.cc
+++ b/chrome/browser/memory/tab_manager_web_contents_data.cc
@@ -98,12 +98,8 @@ void TabManager::WebContentsData::SetDiscardState(bool state) {
}
tab_data_.is_discarded_ = state;
-
- // TabManager could not exist in tests.
- if (g_browser_process->GetTabManager()) {
- g_browser_process->GetTabManager()->OnDiscardedStateChange(web_contents(),
- state);
- }
+ g_browser_process->GetTabManager()->OnDiscardedStateChange(web_contents(),
+ state);
}
int TabManager::WebContentsData::DiscardCount() {
@@ -172,7 +168,8 @@ TabManager::WebContentsData::Data::Data()
last_discard_time_(TimeTicks::UnixEpoch()),
last_reload_time_(TimeTicks::UnixEpoch()),
last_inactive_time_(TimeTicks::UnixEpoch()),
- engagement_score_(-1.0) {}
+ engagement_score_(-1.0),
+ is_auto_discardable(true) {}
bool TabManager::WebContentsData::Data::operator==(const Data& right) const {
return is_discarded_ == right.is_discarded_ &&
@@ -188,4 +185,17 @@ bool TabManager::WebContentsData::Data::operator!=(const Data& right) const {
return !(*this == right);
}
+void TabManager::WebContentsData::SetAutoDiscardableState(bool state) {
+ if (tab_data_.is_auto_discardable == state)
+ return;
+
+ tab_data_.is_auto_discardable = state;
+ g_browser_process->GetTabManager()->OnAutoDiscardableStateChange(
+ web_contents(), state);
+}
+
+bool TabManager::WebContentsData::IsAutoDiscardable() {
+ return tab_data_.is_auto_discardable;
+}
+
} // namespace memory
« no previous file with comments | « chrome/browser/memory/tab_manager_web_contents_data.h ('k') | chrome/browser/memory/tab_stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698