Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: chrome/browser/memory/tab_manager.h

Issue 2167843004: Discardable property support on TabManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed nit on comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/memory/tab_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory/tab_manager.h
diff --git a/chrome/browser/memory/tab_manager.h b/chrome/browser/memory/tab_manager.h
index cd5c3480417bf76976c8a3849ae4d0e5fe6c5057..715f1b739f127084d133626e3244c45c77368f42 100644
--- a/chrome/browser/memory/tab_manager.h
+++ b/chrome/browser/memory/tab_manager.h
@@ -128,7 +128,18 @@ class TabManager : public TabStripModelObserver {
void AddObserver(TabManagerObserver* observer);
void RemoveObserver(TabManagerObserver* observer);
+ // Returns the auto discardable state of the tab. When true, the tab is
chrisha 2016/07/22 19:16:36 auto-discardable (here and elsewhere)
+ // eligible to be automatically discarded when critical memory pressure hits,
+ // otherwise the tab is ignored and will never be automatically discarded.
+ // Note that this property doesn't block the discarding of the tab via other
+ // methods (about:discards for instance).
+ bool IsTabAutoDiscardable(content::WebContents* contents) const;
+
+ // Sets/clears the auto discardable state of the tab.
+ void SetTabAutoDiscardableState(content::WebContents* contents, bool state);
+
private:
+ FRIEND_TEST_ALL_PREFIXES(TabManagerTest, AutoDiscardable);
FRIEND_TEST_ALL_PREFIXES(TabManagerTest, CanOnlyDiscardOnce);
FRIEND_TEST_ALL_PREFIXES(TabManagerTest, ChildProcessNotifications);
FRIEND_TEST_ALL_PREFIXES(TabManagerTest, Comparator);
@@ -151,6 +162,11 @@ class TabManager : public TabStripModelObserver {
void OnDiscardedStateChange(content::WebContents* contents,
bool is_discarded);
+ // Called by WebContentsData whenever the auto discardable state of a
+ // WebContents changes, so that observers can be informed.
+ void OnAutoDiscardableStateChange(content::WebContents* contents,
+ bool is_auto_discardable);
+
// The time that a renderer is given to react to a memory pressure
// notification before another renderer is also notified. This prevents all
// renderers from receiving and acting upon notifications simultaneously,
« no previous file with comments | « no previous file | chrome/browser/memory/tab_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698