Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2167823002: Build expat from source when using afl_expat_xml_parse_fuzzer (Closed)

Created:
4 years, 5 months ago by Jonathan Metzman
Modified:
4 years, 5 months ago
Reviewers:
jam, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build expat from source when using afl_expat_xml_parse_fuzzer Build expat from source so that it can be instrumented when building the expat fuzzer with use_afl. TBR=jam@chromium.org BUG=629258 Committed: https://crrev.com/74ed884d4d42cb7152dc75fae33351e8e34220cd Cr-Commit-Position: refs/heads/master@{#406716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/expat/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Jonathan Metzman
4 years, 5 months ago (2016-07-20 20:12:36 UTC) #2
inferno
lgtm
4 years, 5 months ago (2016-07-20 20:16:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167823002/1
4 years, 5 months ago (2016-07-20 20:16:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/204576)
4 years, 5 months ago (2016-07-20 20:20:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167823002/1
4 years, 5 months ago (2016-07-20 23:30:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 23:53:43 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/74ed884d4d42cb7152dc75fae33351e8e34220cd Cr-Commit-Position: refs/heads/master@{#406716}
4 years, 5 months ago (2016-07-20 23:55:40 UTC) #16
jam
not sure why I got added as a reviewer. I don't know who maintains this ...
4 years, 5 months ago (2016-07-21 00:48:00 UTC) #17
aarya
4 years, 5 months ago (2016-07-21 02:29:29 UTC) #18
Message was sent while issue was closed.
On 2016/07/21 00:48:00, jam wrote:
> not sure why I got added as a reviewer.
> 
> I don't know who maintains this now, but they should be in an owners file
there.

There is no owners file in third_party/expat, so we just went with
higher-directory third_party/ OWNERS.

Powered by Google App Engine
This is Rietveld 408576698