have MakeFromImage fission the SkImage into a raster or a texture

have MakeFromImage fission the SkImage into a raster or a texture

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167813002

Committed: https://skia.googlesource.com/skia/+/a61bfc6292edb990eae0b948648016550ef739a9

[reed1, 2016-07-20 20:03:02]

Description was changed from

==========
have MakeFromImage fission the SkImage into a raster or a texture

BUG=skia:
==========

to

==========
have MakeFromImage fission the SkImage into a raster or a texture

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167813002
==========

[reed1, 2016-07-20 20:03:19]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2016-07-20 20:03:19]

ptal

[reed1, 2016-07-20 20:03:23]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-07-20 20:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-07-20 21:20:58]

Very nice - lgtm

https://codereview.chromium.org/2167813002/diff/1/src/core/SkSpecialImage.cpp
File src/core/SkSpecialImage.cpp (right):

https://codereview.chromium.org/2167813002/diff/1/src/core/SkSpecialImage.cpp...
src/core/SkSpecialImage.cpp:22: #include "SkGr.h"
Do we still need SkGrPixelRef.h ?

[commit-bot: I haz the power, 2016-07-20 21:22:40]

Description was changed from

==========
have MakeFromImage fission the SkImage into a raster or a texture

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167813002
==========

to

==========
have MakeFromImage fission the SkImage into a raster or a texture

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167813002

Committed:
https://skia.googlesource.com/skia/+/a61bfc6292edb990eae0b948648016550ef739a9
==========

[commit-bot: I haz the power, 2016-07-20 21:22:41]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a61bfc6292edb990eae0b948648016550ef739a9

[reed1, 2016-07-20 21:24:52]

On 2016/07/20 21:20:58, robertphillips wrote:
> Very nice - lgtm
> 
> https://codereview.chromium.org/2167813002/diff/1/src/core/SkSpecialImage.cpp
> File src/core/SkSpecialImage.cpp (right):
> 
>
https://codereview.chromium.org/2167813002/diff/1/src/core/SkSpecialImage.cpp...
> src/core/SkSpecialImage.cpp:22: #include "SkGr.h"
> Do we still need SkGrPixelRef.h ?

Still needed : line 383

[reed1, 2016-07-20 22:37:59]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2168643003/ by reed@google.com.

The reason for reverting is: broke ios build in chrome -- no_gpu?.