OLD | NEW |
1 Tree Sheriffs Documentation | 1 Tree Sheriffs Documentation |
2 =========================== | 2 =========================== |
3 | 3 |
4 ### Contents ### | 4 ### Contents ### |
5 | 5 |
6 * [What does a sheriff do?](#what_is_a_sheriff) | 6 * [What does a sheriff do?](#what_is_a_sheriff) |
7 + [Skia tree](#skia_tree) | 7 + [Skia tree](#skia_tree) |
8 + [DEPS rolls](#deps_rolls) | 8 + [DEPS rolls](#deps_rolls) |
9 + [Gold and Perf](#gold_and_perf) | 9 + [Gold and Perf](#gold_and_perf) |
10 + [Documentation](#sheriff_doc) | 10 + [Documentation](#sheriff_doc) |
(...skipping 13 matching lines...) Expand all Loading... |
24 ----------------------- | 24 ----------------------- |
25 | 25 |
26 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool. | 26 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool. |
27 | 27 |
28 Below is a brief summary of what the sheriff does for each task: | 28 Below is a brief summary of what the sheriff does for each task: |
29 | 29 |
30 <a name="skia_tree"></a> | 30 <a name="skia_tree"></a> |
31 ### Skia tree | 31 ### Skia tree |
32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo
t). | 32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo
t). |
33 * Start watching the [status page](https://status.skia.org) for bot breakages. | 33 * Start watching the [status page](https://status.skia.org) for bot breakages. |
34 * Track down people responsible for breakages and revert broken changes if there
is no easy fix. | 34 * Track down people responsible for breakages and revert broken changes if there
is no easy fix. You can use [blamer](#blamer) to help track down such changes. |
35 * Close and open the [tree](http://skia-tree-status.appspot.com). | 35 * Close and open the [tree](http://skia-tree-status.appspot.com). |
36 * Keep the builder comments on the [status page](https://status.skia.org) up to
date. | 36 * Keep the builder comments on the [status page](https://status.skia.org) up to
date. |
37 * File or follow up with [BreakingTheBuildbots bugs](https://bug.skia.org/?q=lab
el:BreakingTheBuildbots). See the tip on [when to file bugs](#when_to_file_bugs)
. | 37 * File or follow up with [BreakingTheBuildbots bugs](https://bug.skia.org/?q=lab
el:BreakingTheBuildbots). See the tip on [when to file bugs](#when_to_file_bugs)
. |
38 | 38 |
| 39 <a name="blamer"></a> |
| 40 ### Blamer |
| 41 If you have Go installed, a command-line tool is available to search through |
| 42 git history and do text searches on the full patch text and the commit |
| 43 message. To install blamer run: |
| 44 |
| 45 go get go.skia.org/infra/blamer/go/blamer |
| 46 |
| 47 Then run blamer from within a Skia checkout. For example, to search if the |
| 48 string "SkDevice" has appeared in the last 10 commits: |
| 49 |
| 50 $ $GOPATH/bin/blamer --match SkDevice --num 10 |
| 51 |
| 52 commit ea70c4bb22394c8dcc29a369d3422a2b8f3b3e80 |
| 53 Author: robertphillips <robertphillips@google.com> |
| 54 Date: Wed Jul 20 08:54:31 2016 -0700 |
| 55 |
| 56 Remove SkDevice::accessRenderTarget virtual |
| 57 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002 |
| 58 |
| 59 Review-Url: https://codereview.chromium.org/2167723002 |
| 60 |
39 <a name="deps_rolls"></a> | 61 <a name="deps_rolls"></a> |
40 ### DEPS rolls | 62 ### DEPS rolls |
41 * Ensure that [AutoRoll Bot](https://autoroll.skia.org)'s DEPS rolls land succes
sfully. | 63 * Ensure that [AutoRoll Bot](https://autoroll.skia.org)'s DEPS rolls land succes
sfully. |
42 | 64 |
43 <a name="gold_and_perf"></a> | 65 <a name="gold_and_perf"></a> |
44 ### Gold and Perf | 66 ### Gold and Perf |
45 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s
kia.org/) alerts (by clicking on the bell at the top right of the [status page](
https://status.skia.org)). | 67 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s
kia.org/) alerts (by clicking on the bell at the top right of the [status page](
https://status.skia.org)). |
46 * The sheriff's duty here is to make sure that when developers introduce new ima
ges or new perf regressions, that they are aware of what happened, and they use
these tools to take appropriate action. | 68 * The sheriff's duty here is to make sure that when developers introduce new ima
ges or new perf regressions, that they are aware of what happened, and they use
these tools to take appropriate action. |
47 | 69 |
48 <a name="sheriff_doc"></a> | 70 <a name="sheriff_doc"></a> |
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
152 * Add # comment about what has changed | 174 * Add # comment about what has changed |
153 * Add line(s) like the following after the comment: | 175 * Add line(s) like the following after the comment: |
154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline
] | 176 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline
] |
155 * (if you took the second option above you can just edit the existing li
ne(s)) | 177 * (if you took the second option above you can just edit the existing li
ne(s)) |
156 | 178 |
157 * If you took the first/dispreferred option above: | 179 * If you took the first/dispreferred option above: |
158 * Wait for the Blink patch to roll into Chrome | 180 * Wait for the Blink patch to roll into Chrome |
159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp
ectations.txt | 181 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp
ectations.txt |
160 | 182 |
161 | 183 |
OLD | NEW |