Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 21678003: Remove redundant call of argsList->current() from loops in CSSParser (Closed)

Created:
7 years, 4 months ago by byungwoo
Modified:
7 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove redundant call of argsList->current() from loops in CSSParser while loops in CSSParser call argList->current() function at the start of each iteration, but this is redundant because argsList->next() at the end of the iteration calls the argList->current() and returns the result. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M Source/core/css/CSSParser-in.cpp View 6 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haraken
Looks OK. LGTM. Why are try bots red?
7 years, 4 months ago (2013-08-02 02:10:01 UTC) #1
byungwoo
On 2013/08/02 02:10:01, haraken wrote: > Looks OK. LGTM. > > Why are try bots ...
7 years, 4 months ago (2013-08-02 02:12:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bw80.lee@samsung.com/21678003/1
7 years, 4 months ago (2013-08-02 02:17:24 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-02 05:24:33 UTC) #4
Message was sent while issue was closed.
Change committed as 155402

Powered by Google App Engine
This is Rietveld 408576698