Fix the definition of the syzygy_optimize variable in GN

Fix the definition of the syzygy_optimize variable in GN

Remove the 'symbol_level==2' condition as we can assume than an official build (without fast link) will have symbols.

R=dpranke@chromium.org
BUG=628056
Committed: https://crrev.com/17502ed46616115c1586a0c99375c9be93441c70
Cr-Commit-Position: refs/heads/master@{#406698}

[Sébastien Marchand, 2016-07-20 19:56:42]

Description was changed from

==========
Fix the definition of the syzygy_optimize variable in GN

R=dpranke@chromium.org
BUG=628056
==========

to

==========
Fix the definition of the syzygy_optimize variable in GN

Remove the 'symbol_level==2' condition as we can assume than an official build
(without fast link) will have symbols.

R=dpranke@chromium.org
BUG=628056
==========

[Sébastien Marchand, 2016-07-20 19:56:48]

PTAL.

[Dirk Pranke, 2016-07-20 21:20:34]

lgtm

https://codereview.chromium.org/2167793002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2167793002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:65: !is_clang && !is_win_fastlink
I wonder if it's really sensible to have (is_official_build && is_win_fastlink),
but that's probably something we can worry about at another time.

[Sébastien Marchand, 2016-07-20 21:29:50]

https://codereview.chromium.org/2167793002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2167793002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:65: !is_clang && !is_win_fastlink
On 2016/07/20 21:20:33, Dirk Pranke wrote:
> I wonder if it's really sensible to have (is_official_build &&
is_win_fastlink),
> but that's probably something we can worry about at another time.

I think that we have some public bots that do a fast link official build (or we
wanted some)

[Sébastien Marchand, 2016-07-20 21:29:55]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:30:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-07-20 21:40:19]

On 2016/07/20 21:29:50, Sébastien Marchand wrote:
> On 2016/07/20 21:20:33, Dirk Pranke wrote:
> > I wonder if it's really sensible to have (is_official_build &&
> is_win_fastlink),
> > but that's probably something we can worry about at another time.
> 
> I think that we have some public bots that do a fast link official build (or
we
> wanted some)

We don't currently have any builders that set fastlink at all.

[Sébastien Marchand, 2016-07-20 21:45:12]

Hum, I think that I'm confusing this with fastbuild then, it might be safe to
remove this but I'm pretty sure that Syzygy won't work with fastlink anyway, so
it doesn't hurt to keep it.

[commit-bot: I haz the power, 2016-07-20 22:37:08]

Description was changed from

==========
Fix the definition of the syzygy_optimize variable in GN

Remove the 'symbol_level==2' condition as we can assume than an official build
(without fast link) will have symbols.

R=dpranke@chromium.org
BUG=628056
==========

to

==========
Fix the definition of the syzygy_optimize variable in GN

Remove the 'symbol_level==2' condition as we can assume than an official build
(without fast link) will have symbols.

R=dpranke@chromium.org
BUG=628056

Committed: https://crrev.com/17502ed46616115c1586a0c99375c9be93441c70
Cr-Commit-Position: refs/heads/master@{#406698}
==========

[commit-bot: I haz the power, 2016-07-20 22:37:09]

Patchset 1 (id:??) landed as
https://crrev.com/17502ed46616115c1586a0c99375c9be93441c70
Cr-Commit-Position: refs/heads/master@{#406698}

[commit-bot: I haz the power, 2016-07-20 22:37:42]

Failed to apply the patch.