Issue 2167773007: Use local variable/function index in its enclosing executable as a part of the identifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2167773007: Use local variable/function index in its enclosing executable as a part of the identifier. (Closed)

Created:
4 years, 5 months ago by scheglov

Modified:
4 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use local variable/function index in its enclosing executable as a part of the identifier. This makes these identifiers stable as long as the executable's body is not changed, in which case we should get rid of these locals anyway. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d382ca6d0998b00d5bc1d84ca34373cb08b6ae7b

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -93 lines)			Patch
M	pkg/analyzer/lib/src/context/cache.dart	View	3 chunks	+1 line, -16 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/element/element.dart	View	9 chunks	+21 lines, -61 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	2 chunks	+13 lines, -8 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	2 chunks	+35 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 5 months ago (2016-07-21 21:32:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d382ca6d0998b00d5bc1d84ca34373cb08b6ae7b (presubmit successful).