Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 2167763003: [Interpreter] Avoid allocating pairs array in VisitDeclarations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_merge_binary
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
index 4194e85c2597f0f1eeaf4707f197bc72d6e8305c..967b8de8abb16abb65d982053e39710c5e00d86e 100644
--- a/src/interpreter/bytecode-array-builder.cc
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -179,6 +179,12 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::CompareOperation(Token::Value op,
return *this;
}
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadConstantPoolEntry(
+ size_t entry) {
+ Output(Bytecode::kLdaConstant, UnsignedOperand(entry));
+ return *this;
+}
+
BytecodeArrayBuilder& BytecodeArrayBuilder::LoadLiteral(
v8::internal::Smi* smi) {
int32_t raw_smi = smi->value();
@@ -632,6 +638,15 @@ size_t BytecodeArrayBuilder::GetConstantPoolEntry(Handle<Object> object) {
return constant_array_builder()->Insert(object);
}
+size_t BytecodeArrayBuilder::ReserveConstantPoolEntry() {
+ return constant_array_builder()->ReserveEntry();
+}
+
+void BytecodeArrayBuilder::InsertReservedConstantPoolEntry(
+ size_t entry, Handle<Object> object) {
+ constant_array_builder()->InsertReservedEntry(entry, object);
+}
+
void BytecodeArrayBuilder::SetReturnPosition() {
if (return_position_ == kNoSourcePosition) return;
latest_source_info_.MakeStatementPosition(return_position_);

Powered by Google App Engine
This is Rietveld 408576698