[Interpreter] Avoid allocating pairs array in VisitDeclarations.

[Interpreter] Avoid allocating pairs array in VisitDeclarations.

Move the logic for allocating the global declaration pair array
from VisitDeclarations to a later step. This is required for
concurrent bytecode generation.

This change requires adding support for reserving fixed
constant pool array entries, which can be later updated
with the value of the literal.

BUG=v8:5203
Committed: https://crrev.com/8d4658077ca9f35904cefe0fb1cb4e927ea9f240
Cr-Commit-Position: refs/heads/master@{#38010}

[rmcilroy, 2016-07-20 21:13:09]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-07-20 21:31:45]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-07-20 21:31:50]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:31:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 21:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:34:04]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9413)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/10918)

[rmcilroy, 2016-07-20 21:49:52]

Patchset #1 (id:20001) has been deleted

[rmcilroy, 2016-07-20 21:49:59]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:50:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 22:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:18:36]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-07-21 07:44:09]

rmcilroy@chromium.org changed reviewers:
+ mythria@chromium.org, oth@chromium.org

[rmcilroy, 2016-07-21 07:44:09]

Mythri, Orion, please take a look, thanks.

[mythria, 2016-07-22 09:36:25]

lgtm.

Thanks,
Mythri

[oth, 2016-07-22 10:22:10]

LGTM modulo trivial comments.

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
File src/interpreter/constant-array-builder.cc (right):

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
src/interpreter/constant-array-builder.cc:49: void
ConstantArrayBuilder::ConstantArraySlice::Update(size_t index,
Is this a once only operation?

If so could the code also DCHECK the cell is empty and call the method
InsertAt()/Bind()/Set() or somesuch.

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
File src/interpreter/constant-array-builder.h (right):

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
src/interpreter/constant-array-builder.h:62: OperandSize
CreateDiscardableReservedEntry();
The names here used to align to give a hint that it was a group of related
methods, e.g. CreateReservedEntry, CommitReservedEntry, DiscardReservedEntry.

How about something like:

s/ReserveEntry/AllocateEntry/
s/InsertReservedEntry/BindAllocatedEntry/
s/CreateDiscardableReservedEntry/CreateReservedEntry/

[rmcilroy, 2016-07-25 10:55:29]

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
File src/interpreter/constant-array-builder.cc (right):

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
src/interpreter/constant-array-builder.cc:49: void
ConstantArrayBuilder::ConstantArraySlice::Update(size_t index,
On 2016/07/22 10:22:10, oth wrote:
> Is this a once only operation?
> 
> If so could the code also DCHECK the cell is empty and call the method
> InsertAt()/Bind()/Set() or somesuch.

InsertAt sounds good. I can't have the DCHECK here since ConstantPoolSlice has
no isolate field, but there was already a similar DCHECK at InsertReservedEntry.

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
File src/interpreter/constant-array-builder.h (right):

https://codereview.chromium.org/2167763003/diff/40001/src/interpreter/constan...
src/interpreter/constant-array-builder.h:62: OperandSize
CreateDiscardableReservedEntry();
On 2016/07/22 10:22:10, oth wrote:
> The names here used to align to give a hint that it was a group of related
> methods, e.g. CreateReservedEntry, CommitReservedEntry, DiscardReservedEntry.
> 
> How about something like:
> 
> s/ReserveEntry/AllocateEntry/
> s/InsertReservedEntry/BindAllocatedEntry/
> s/CreateDiscardableReservedEntry/CreateReservedEntry/
> 

SGTM (/s/BindAllocatedEntry/InsertAllocatedEntry). Done.

[rmcilroy, 2016-07-25 10:58:58]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-07-25 10:58:58]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/2167763003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-25 10:59:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 11:30:42]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-07-25 11:31:14]

Description was changed from

==========
[Interpreter] Avoid allocating pairs array in VisitDeclarations.

Move the logic for allocating the global declaration pair array
from VisitDeclarations to a later step. This is required for
concurrent bytecode generation.

This change requires adding support for reserving fixed
constant pool array entries, which can be later updated
with the value of the literal.

BUG=v8:5203
==========

to

==========
[Interpreter] Avoid allocating pairs array in VisitDeclarations.

Move the logic for allocating the global declaration pair array
from VisitDeclarations to a later step. This is required for
concurrent bytecode generation.

This change requires adding support for reserving fixed
constant pool array entries, which can be later updated
with the value of the literal.

BUG=v8:5203

Committed: https://crrev.com/8d4658077ca9f35904cefe0fb1cb4e927ea9f240
Cr-Commit-Position: refs/heads/master@{#38010}
==========

[commit-bot: I haz the power, 2016-07-25 11:31:15]

Patchset 3 (id:??) landed as
https://crrev.com/8d4658077ca9f35904cefe0fb1cb4e927ea9f240
Cr-Commit-Position: refs/heads/master@{#38010}