Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2167743002: Convert media-document* and pdf* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert media-document* and pdf* tests to testharness.js Cleaning up media-document* and pdf* tests in http/tests/media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/4ef536c99a67ddd6b68433079c8e0bf88262ddd8 Cr-Commit-Position: refs/heads/master@{#406582}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add suggested change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -78 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/media/media-document.html View 1 chunk +19 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/media/media-document-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html View 1 1 chunk +15 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Srirama
I Just realized that there are tests to be converted in http/ as well. PTAL.
4 years, 5 months ago (2016-07-20 14:45:23 UTC) #3
Srirama
https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/media-document.html File third_party/WebKit/LayoutTests/http/tests/media/media-document.html (left): https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/media-document.html#oldcode18 third_party/WebKit/LayoutTests/http/tests/media/media-document.html:18: waitForEventAndFail('error'); these events are added to "document" and they ...
4 years, 5 months ago (2016-07-20 14:46:56 UTC) #4
fs
lgtm https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html (right): https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html#newcode14 third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14: assert_equals(video.error, null); unreached_func on loadedmetadata too?
4 years, 5 months ago (2016-07-20 14:58:25 UTC) #5
Srirama
https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html (right): https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html#newcode14 third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14: assert_equals(video.error, null); On 2016/07/20 14:58:25, fs wrote: > unreached_func ...
4 years, 5 months ago (2016-07-20 15:00:31 UTC) #6
Srirama
On 2016/07/20 15:00:31, Srirama wrote: > https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html > File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html > (right): > > https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html#newcode14 ...
4 years, 5 months ago (2016-07-20 15:04:18 UTC) #7
fs
On 2016/07/20 at 15:04:18, srirama.m wrote: > On 2016/07/20 15:00:31, Srirama wrote: > > https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html ...
4 years, 5 months ago (2016-07-20 15:07:25 UTC) #8
Srirama
https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html (right): https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html#newcode14 third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14: assert_equals(video.error, null); On 2016/07/20 14:58:25, fs wrote: > unreached_func ...
4 years, 5 months ago (2016-07-20 15:19:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167743002/40001
4 years, 5 months ago (2016-07-20 15:20:18 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-20 16:36:42 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 16:36:44 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 16:38:25 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ef536c99a67ddd6b68433079c8e0bf88262ddd8
Cr-Commit-Position: refs/heads/master@{#406582}

Powered by Google App Engine
This is Rietveld 408576698