Convert media-document* and pdf* tests to testharness.js

Convert media-document* and pdf* tests to testharness.js

Cleaning up media-document* and pdf* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/4ef536c99a67ddd6b68433079c8e0bf88262ddd8
Cr-Commit-Position: refs/heads/master@{#406582}

[Srirama, 2016-07-20 14:42:30]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert media-document* and pdf* tests to testharness.js

Cleaning up media-document* and pdf* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-07-20 14:45:22]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-07-20 14:45:23]

I Just realized that there are tests to be converted in http/ as well.
PTAL.

[Srirama, 2016-07-20 14:46:56]

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/media-document.html (left):

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/media-document.html:18:
waitForEventAndFail('error');
these events are added to "document" and they are not having any effect, so
removed these.

[fs, 2016-07-20 14:58:25]

lgtm

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html
(right):

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14:
assert_equals(video.error, null);
unreached_func on loadedmetadata too?

[Srirama, 2016-07-20 15:00:31]

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html
(right):

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14:
assert_equals(video.error, null);
On 2016/07/20 14:58:25, fs wrote:
> unreached_func on loadedmetadata too?

EventWatcher anyway throws error if loadedmetadata is fired right?

[Srirama, 2016-07-20 15:04:18]

On 2016/07/20 15:00:31, Srirama wrote:
>
https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html
> (right):
> 
>
https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14:
> assert_equals(video.error, null);
> On 2016/07/20 14:58:25, fs wrote:
> > unreached_func on loadedmetadata too?
> 
> EventWatcher anyway throws error if loadedmetadata is fired right?

sorry, I think it watches only the registered events. I will add it.

[fs, 2016-07-20 15:07:25]

On 2016/07/20 at 15:04:18, srirama.m wrote:
> On 2016/07/20 15:00:31, Srirama wrote:
> >
https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
> > File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html
> > (right):
> > 
> >
https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
> > third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14:
> > assert_equals(video.error, null);
> > On 2016/07/20 14:58:25, fs wrote:
> > > unreached_func on loadedmetadata too?
> > 
> > EventWatcher anyway throws error if loadedmetadata is fired right?
> 
> sorry, I think it watches only the registered events. I will add it.

I think you could have it in 'eventTypes' (i.e when constructing the
EventWatcher) but then just not include it in wait_for.

[Srirama, 2016-07-20 15:18:43]

Patchset #2 (id:20001) has been deleted

[Srirama, 2016-07-20 15:19:22]

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html
(right):

https://codereview.chromium.org/2167743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/pdf-served-as-pdf.html:14:
assert_equals(video.error, null);
On 2016/07/20 14:58:25, fs wrote:
> unreached_func on loadedmetadata too?

Done.

[Srirama, 2016-07-20 15:19:51]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-07-20 15:19:51]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2167743002/#ps40001
(title: "add suggested change")

[commit-bot: I haz the power, 2016-07-20 15:20:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:36:41]

Description was changed from

==========
Convert media-document* and pdf* tests to testharness.js

Cleaning up media-document* and pdf* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert media-document* and pdf* tests to testharness.js

Cleaning up media-document* and pdf* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-07-20 16:36:42]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-20 16:36:44]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 16:38:23]

Description was changed from

==========
Convert media-document* and pdf* tests to testharness.js

Cleaning up media-document* and pdf* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert media-document* and pdf* tests to testharness.js

Cleaning up media-document* and pdf* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/4ef536c99a67ddd6b68433079c8e0bf88262ddd8
Cr-Commit-Position: refs/heads/master@{#406582}
==========

[commit-bot: I haz the power, 2016-07-20 16:38:25]

Patchset 2 (id:??) landed as
https://crrev.com/4ef536c99a67ddd6b68433079c8e0bf88262ddd8
Cr-Commit-Position: refs/heads/master@{#406582}