Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2167723003:
Rebaseline video-poster-scale.html on Mac. (Closed)
|
Created:
4 years, 5 months ago by Srirama Modified:
4 years, 5 months ago CC:
chromium-reviews, blink-reviews, posciak+watch_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRebaseline video-poster-scale.html on Mac.
BUG=588956
Committed: https://crrev.com/8fc82e7d69ae94b973053346d82f33b02c013477
Cr-Commit-Position: refs/heads/master@{#406811}
Patch Set 1 #
Messages
Total messages: 16 (5 generated)
Description was changed from ========== fix fix BUG= ========== to ========== Rebaseline video-poster-scale.html on Mac. BUG=588956 ==========
srirama.m@samsung.com changed reviewers: + foolip@chromium.org, fs@opera.com
Looks like video-poster-scale-expected.txt was not added in mac in rebaseline https://codereview.chromium.org/2168643002/ may be because LayoutTests/media/video-poster-scale-expected.txt was not deleted. Also there is a problem in windows build, the space character height looks flaky (17px or 18px). Please check comments 111 to 113 in crbug.com/588956. So should we mark it as "pass fail" for windows?
On 2016/07/21 at 07:44:56, srirama.m wrote: > Looks like video-poster-scale-expected.txt was not added in mac in rebaseline https://codereview.chromium.org/2168643002/ may be because LayoutTests/media/video-poster-scale-expected.txt was not deleted. Odd. > Also there is a problem in windows build, the space character height looks flaky (17px or 18px). Please check comments 111 to 113 in crbug.com/588956. I didn't see that on http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec... - on waterfall bots only? > So should we mark it as "pass fail" for windows? I guess. Feel free to TBR that. LGTM
On 2016/07/21 08:50:54, fs wrote: > On 2016/07/21 at 07:44:56, srirama.m wrote: > > Looks like video-poster-scale-expected.txt was not added in mac in rebaseline > https://codereview.chromium.org/2168643002/ may be because > LayoutTests/media/video-poster-scale-expected.txt was not deleted. > > Odd. > > > Also there is a problem in windows build, the space character height looks > flaky (17px or 18px). Please check comments 111 to 113 in crbug.com/588956. > > I didn't see that on > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec... > - on waterfall bots only? Yes, i think it is consistently inconsistent(same value on both trials), so it is not shown on flakiness dashboard. > > So should we mark it as "pass fail" for windows? > > I guess. Feel free to TBR that. > > LGTM
The CQ bit was checked by srirama.m@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/21 at 09:18:22, srirama.m wrote: > On 2016/07/21 08:50:54, fs wrote: > > On 2016/07/21 at 07:44:56, srirama.m wrote: > > > Looks like video-poster-scale-expected.txt was not added in mac in rebaseline > > https://codereview.chromium.org/2168643002/ may be because > > LayoutTests/media/video-poster-scale-expected.txt was not deleted. > > > > Odd. > > > > > Also there is a problem in windows build, the space character height looks > > flaky (17px or 18px). Please check comments 111 to 113 in crbug.com/588956. > > > > I didn't see that on > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec... > > - on waterfall bots only? > > Yes, i think it is consistently inconsistent(same value on both trials), so it is not shown on flakiness dashboard. Then it would show up above (as some sort of failure - TEXT I guess?) I don't see this on the waterfal either - could provide a link?
On 2016/07/21 09:24:31, fs wrote: > On 2016/07/21 at 09:18:22, srirama.m wrote: > > On 2016/07/21 08:50:54, fs wrote: > > > On 2016/07/21 at 07:44:56, srirama.m wrote: > > > > Looks like video-poster-scale-expected.txt was not added in mac in > rebaseline > > > https://codereview.chromium.org/2168643002/ may be because > > > LayoutTests/media/video-poster-scale-expected.txt was not deleted. > > > > > > Odd. > > > > > > > Also there is a problem in windows build, the space character height looks > > > flaky (17px or 18px). Please check comments 111 to 113 in crbug.com/588956. > > > > > > I didn't see that on > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec... > > > - on waterfall bots only? > > > > Yes, i think it is consistently inconsistent(same value on both trials), so it > is not shown on flakiness dashboard. > > Then it would show up above (as some sort of failure - TEXT I guess?) I don't > see this on the waterfal either - could provide a link? Sorry, i misread comments from Charlie. I think i downloaded layout test results from mac builder which he pointed out and compared with windows rebase file (at the time when i opened his CL there is a failure in windows builder). I think there is no issue in windows. Please ignore.
On 2016/07/21 at 09:41:37, srirama.m wrote: > On 2016/07/21 09:24:31, fs wrote: > > On 2016/07/21 at 09:18:22, srirama.m wrote: > > > On 2016/07/21 08:50:54, fs wrote: > > > > On 2016/07/21 at 07:44:56, srirama.m wrote: > > > > > Looks like video-poster-scale-expected.txt was not added in mac in > > rebaseline > > > > https://codereview.chromium.org/2168643002/ may be because > > > > LayoutTests/media/video-poster-scale-expected.txt was not deleted. > > > > > > > > Odd. > > > > > > > > > Also there is a problem in windows build, the space character height looks > > > > flaky (17px or 18px). Please check comments 111 to 113 in crbug.com/588956. > > > > > > > > I didn't see that on > > > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec... > > > > - on waterfall bots only? > > > > > > Yes, i think it is consistently inconsistent(same value on both trials), so it > > is not shown on flakiness dashboard. > > > > Then it would show up above (as some sort of failure - TEXT I guess?) I don't > > see this on the waterfal either - could provide a link? > > Sorry, i misread comments from Charlie. I think i downloaded layout test results from mac builder which he pointed out and compared with windows rebase file (at the time when i opened his CL there is a failure in windows builder). > I think there is no issue in windows. Please ignore. If you check the link above you'll see that it sometimes (flakily) fails (IMAGE), but it ends up passing once in the retry (purple box)
Message was sent while issue was closed.
Description was changed from ========== Rebaseline video-poster-scale.html on Mac. BUG=588956 ========== to ========== Rebaseline video-poster-scale.html on Mac. BUG=588956 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Rebaseline video-poster-scale.html on Mac. BUG=588956 ========== to ========== Rebaseline video-poster-scale.html on Mac. BUG=588956 Committed: https://crrev.com/8fc82e7d69ae94b973053346d82f33b02c013477 Cr-Commit-Position: refs/heads/master@{#406811} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8fc82e7d69ae94b973053346d82f33b02c013477 Cr-Commit-Position: refs/heads/master@{#406811}
Message was sent while issue was closed.
On 2016/07/21 10:19:34, fs wrote: > On 2016/07/21 at 09:41:37, srirama.m wrote: > > On 2016/07/21 09:24:31, fs wrote: > > > On 2016/07/21 at 09:18:22, srirama.m wrote: > > > > On 2016/07/21 08:50:54, fs wrote: > > > > > On 2016/07/21 at 07:44:56, srirama.m wrote: > > > > > > Looks like video-poster-scale-expected.txt was not added in mac in > > > rebaseline > > > > > https://codereview.chromium.org/2168643002/ may be because > > > > > LayoutTests/media/video-poster-scale-expected.txt was not deleted. > > > > > > > > > > Odd. > > > > > > > > > > > Also there is a problem in windows build, the space character height > looks > > > > > flaky (17px or 18px). Please check comments 111 to 113 in > crbug.com/588956. > > > > > > > > > > I didn't see that on > > > > > > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec... > > > > > - on waterfall bots only? > > > > > > > > Yes, i think it is consistently inconsistent(same value on both trials), > so it > > > is not shown on flakiness dashboard. > > > > > > Then it would show up above (as some sort of failure - TEXT I guess?) I > don't > > > see this on the waterfal either - could provide a link? > > > > Sorry, i misread comments from Charlie. I think i downloaded layout test > results from mac builder which he pointed out and compared with windows rebase > file (at the time when i opened his CL there is a failure in windows builder). > > I think there is no issue in windows. Please ignore. > > If you check the link above you'll see that it sometimes (flakily) fails > (IMAGE), but it ends up passing once in the retry (purple box) ok, even webkit-linux (release) one of the build (light purple) shows flakiness, fails on first attempt and passes on 2nd attempt. Ran locally 1000 times and it is fine. May be we will see the results for a week?
Message was sent while issue was closed.
On 2016/07/21 at 11:18:53, srirama.m wrote: > On 2016/07/21 10:19:34, fs wrote: > > On 2016/07/21 at 09:41:37, srirama.m wrote: > > > On 2016/07/21 09:24:31, fs wrote: > > > > On 2016/07/21 at 09:18:22, srirama.m wrote: > > > > > On 2016/07/21 08:50:54, fs wrote: > > > > > > On 2016/07/21 at 07:44:56, srirama.m wrote: > > > > > > > Looks like video-poster-scale-expected.txt was not added in mac in > > > > rebaseline > > > > > > https://codereview.chromium.org/2168643002/ may be because > > > > > > LayoutTests/media/video-poster-scale-expected.txt was not deleted. > > > > > > > > > > > > Odd. > > > > > > > > > > > > > Also there is a problem in windows build, the space character height > > looks > > > > > > flaky (17px or 18px). Please check comments 111 to 113 in > > crbug.com/588956. > > > > > > > > > > > > I didn't see that on > > > > > > > > > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec... > > > > > > - on waterfall bots only? > > > > > > > > > > Yes, i think it is consistently inconsistent(same value on both trials), > > so it > > > > is not shown on flakiness dashboard. > > > > > > > > Then it would show up above (as some sort of failure - TEXT I guess?) I > > don't > > > > see this on the waterfal either - could provide a link? > > > > > > Sorry, i misread comments from Charlie. I think i downloaded layout test > > results from mac builder which he pointed out and compared with windows rebase > > file (at the time when i opened his CL there is a failure in windows builder). > > > I think there is no issue in windows. Please ignore. > > > > If you check the link above you'll see that it sometimes (flakily) fails > > (IMAGE), but it ends up passing once in the retry (purple box) > > ok, even webkit-linux (release) one of the build (light purple) shows flakiness, fails on first attempt and passes on 2nd attempt. Ran locally 1000 times and it is fine. May be we will see the results for a week? Shouldn't need to wait that long. 1/2-1 day is usually enough. The flake I looked at seemed to be the scrollbar - which is a bit odd. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
