Remove SkDevice::accessRenderTarget virtual

Remove SkDevice::accessRenderTarget virtual
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002

Committed: https://skia.googlesource.com/skia/+/ea70c4bb22394c8dcc29a369d3422a2b8f3b3e80

[robertphillips, 2016-07-20 14:24:05]

Description was changed from

==========
Remove SkDevice::accessRenderTarget virtual
==========

to

==========
Remove SkDevice::accessRenderTarget virtual
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002
==========

[robertphillips, 2016-07-20 14:26:26]

Description was changed from

==========
Remove SkDevice::accessRenderTarget virtual
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002
==========

to

==========
Remove SkDevice::accessRenderTarget virtual
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002
==========

[robertphillips, 2016-07-20 14:26:27]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-07-20 14:34:13]

lgtm

https://codereview.chromium.org/2167723002/diff/1/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/2167723002/diff/1/include/core/SkDevice.h#new...
include/core/SkDevice.h:381: virtual GrDrawContext* accessDrawContext() { return
nullptr; }
Should we allow SkSurface_Gpu (and others) to downcast when they know it's a GPU
surface/canvas and make this non-virtual?

[robertphillips, 2016-07-20 14:49:13]

https://codereview.chromium.org/2167723002/diff/1/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/2167723002/diff/1/include/core/SkDevice.h#new...
include/core/SkDevice.h:381: virtual GrDrawContext* accessDrawContext() { return
nullptr; }
On 2016/07/20 14:34:13, bsalomon wrote:
> Should we allow SkSurface_Gpu (and others) to downcast when they know it's a
GPU
> surface/canvas and make this non-virtual?

Yeah - that would be better. I'll do that in another CL.

[robertphillips, 2016-07-20 14:49:18]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 14:49:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 15:26:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 15:26:28]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-20 15:53:31]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-07-20 15:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 15:54:33]

Description was changed from

==========
Remove SkDevice::accessRenderTarget virtual
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002
==========

to

==========
Remove SkDevice::accessRenderTarget virtual
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002

Committed:
https://skia.googlesource.com/skia/+/ea70c4bb22394c8dcc29a369d3422a2b8f3b3e80
==========

[commit-bot: I haz the power, 2016-07-20 15:54:34]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ea70c4bb22394c8dcc29a369d3422a2b8f3b3e80