Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: src/parsing/rewriter.h

Issue 2167713004: Always finalize blocks after parsing, also for do-expressions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.cc ('k') | src/parsing/rewriter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/rewriter.h
diff --git a/src/parsing/rewriter.h b/src/parsing/rewriter.h
index 477644a7567f92a09a74d67677d62059331dcfbf..b90607489076ddb55f931160339ad16a22b7e490 100644
--- a/src/parsing/rewriter.h
+++ b/src/parsing/rewriter.h
@@ -12,6 +12,7 @@ class AstValueFactory;
class DoExpression;
class ParseInfo;
class Parser;
+class Scope;
class Rewriter {
public:
@@ -24,8 +25,12 @@ class Rewriter {
static bool Rewrite(ParseInfo* info);
// Rewrite a list of statements, using the same rules as a top-level program,
- // to ensure identical behaviour of completion result.
- static bool Rewrite(Parser* parser, DoExpression* expr,
+ // to ensure identical behaviour of completion result. The temporary is added
+ // to the closure scope of the do-expression, which matches the closure scope
+ // of the outer scope (the do-expression itself runs in a block scope, not a
+ // closure scope). This closure scope needs to be passed in since the
+ // do-expression could have dropped its own block scope.
+ static bool Rewrite(Parser* parser, Scope* closure_scope, DoExpression* expr,
AstValueFactory* factory);
};
« no previous file with comments | « src/parsing/parser.cc ('k') | src/parsing/rewriter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698