Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 2167693002: [Autofill] Use AutofillPopupController::GetBackgroundColorForRow on Mac. (Closed)

Created:
4 years, 5 months ago by Mathieu
Modified:
4 years, 5 months ago
Reviewers:
ccameron
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Use AutofillPopupController::GetBackgroundColorForRow on Mac. Kept the Mac system color for highlighting a row. BUG=626442 TEST=Visual Committed: https://crrev.com/7161859bb9790555239d3a8384d188a6d33fbae2 Cr-Commit-Position: refs/heads/master@{#406619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mathieu
Hi Christopher, PTAL, thanks!
4 years, 5 months ago (2016-07-20 13:29:33 UTC) #2
ccameron
lgtm
4 years, 5 months ago (2016-07-20 17:13:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167693002/1
4 years, 5 months ago (2016-07-20 17:21:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 18:10:55 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:13:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7161859bb9790555239d3a8384d188a6d33fbae2
Cr-Commit-Position: refs/heads/master@{#406619}

Powered by Google App Engine
This is Rietveld 408576698