Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2167683004: Clear token streams before compacting the symbol table. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clear token streams before compacting the symbol table. Also fixes size regression introduced by 83da4db9f9f5d8d5894e603c9a10402f328f0aac. BUG=http://dartbug.com/26916 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/db48637ab39adfc79e981a60ab9e3d0b59671323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/precompiler.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
Flutter stock's app Before VMIsolate(CodeSize): 1918017 Isolate(CodeSize): 2163717 Instructions(CodeSize): 6057024 Total(CodeSize): 10138758 After VMIsolate(CodeSize): 95595 ...
4 years, 5 months ago (2016-07-20 19:12:17 UTC) #3
Florian Schneider
LGTM
4 years, 5 months ago (2016-07-20 19:15:01 UTC) #4
rmacnak
4 years, 5 months ago (2016-07-20 19:48:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db48637ab39adfc79e981a60ab9e3d0b59671323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698