Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2167623002: Reload: propagate FrameLoadType to child frames Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add some comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 832f73f5713e9abbf8b9749c400fdca055fd8399..e0c81ca8d8ff97a31231b6304000f9a9fe049d4e 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -109,15 +109,22 @@ using namespace HTMLNames;
bool isBackForwardLoadType(FrameLoadType type)
{
- return type == FrameLoadTypeBackForward || type == FrameLoadTypeInitialHistoryLoad;
+ return type == FrameLoadTypeBackForward
+ || type == FrameLoadTypeInitialHistoryLoad;
}
-static bool needsHistoryItemRestore(FrameLoadType type)
+bool isReloadLoadType(FrameLoadType type)
{
- return type == FrameLoadTypeBackForward || type == FrameLoadTypeReload
+ return type == FrameLoadTypeReload
+ || type == FrameLoadTypeReloadMainResource
|| type == FrameLoadTypeReloadBypassingCache;
}
+static bool needsHistoryItemRestore(FrameLoadType type)
+{
+ return type == FrameLoadTypeBackForward || isReloadLoadType(type);
+}
+
// static
ResourceRequest FrameLoader::resourceRequestFromHistoryItem(HistoryItem* item, WebCachePolicy cachePolicy)
{
@@ -138,7 +145,7 @@ ResourceRequest FrameLoader::resourceRequestFromHistoryItem(HistoryItem* item, W
ResourceRequest FrameLoader::resourceRequestForReload(FrameLoadType frameLoadType,
const KURL& overrideURL, ClientRedirectPolicy clientRedirectPolicy)
{
- ASSERT(frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadMainResource || frameLoadType == FrameLoadTypeReloadBypassingCache);
+ DCHECK(isReloadLoadType(frameLoadType));
WebCachePolicy cachePolicy = frameLoadType == FrameLoadTypeReloadBypassingCache ? WebCachePolicy::BypassingCache : WebCachePolicy::ValidatingCacheData;
if (!m_currentItem)
return ResourceRequest();
@@ -860,7 +867,7 @@ static bool shouldOpenInNewWindow(Frame* targetFrame, const FrameLoadRequest& re
static NavigationType determineNavigationType(FrameLoadType frameLoadType, bool isFormSubmission, bool haveEvent)
{
- bool isReload = frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadMainResource || frameLoadType == FrameLoadTypeReloadBypassingCache;
+ bool isReload = isReloadLoadType(frameLoadType);
bool isBackForward = isBackForwardLoadType(frameLoadType);
if (isFormSubmission)
return (isReload || isBackForward) ? NavigationTypeFormResubmitted : NavigationTypeFormSubmitted;

Powered by Google App Engine
This is Rietveld 408576698