Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2167573002: Revert "Add fast-mode Uri class." (Closed)

Created:
4 years, 5 months ago by keertip
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, mit
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add fast-mode Uri class." This reverts commit 00090a0c7237b636a73f048e53966879e74ec55a. Revert "Fix regression for the one case where we deliberately don't follow the RFC." This reverts commit b39e048c4b74471ad59fa2b62193e4b06055a9df. Revert "Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key." This reverts commit a11ad27723b49939307c69d185d7ad5d783d4f5a. BUG= This was closed without committing, because another CL reverted these commits.

Patch Set 1 #

Patch Set 2 : Revert "Add fast-mode Uri class." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1313 lines, -2653 lines) Patch
M CHANGELOG.md View 1 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/util/fast_uri.dart View 1 chunk +17 lines, -1 line 0 comments Download
M runtime/lib/uri_patch.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M sdk/lib/core/uri.dart View 38 chunks +1283 lines, -2387 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/data_uri_test.dart View 2 chunks +0 lines, -15 lines 0 comments Download
M tests/corelib/uri_test.dart View 5 chunks +4 lines, -234 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
keertip
4 years, 5 months ago (2016-07-20 01:33:51 UTC) #2
Bill Hesse
This CL should also revert 323ca7e410765f98a88d078c8c8c388fd972eba9 which is also called "Add fast-mode Uri class."
4 years, 5 months ago (2016-07-20 11:47:38 UTC) #4
keertip
4 years, 5 months ago (2016-07-20 15:35:23 UTC) #5
On 2016/07/20 11:47:38, Bill Hesse wrote:
> This CL should also revert 323ca7e410765f98a88d078c8c8c388fd972eba9
> which is also called "Add fast-mode Uri class."

Updated to revert 323ca7e410765f98a88d078c8c8c388fd972eba9 too.

Powered by Google App Engine
This is Rietveld 408576698